[ 
https://issues.apache.org/jira/browse/HBASE-18967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16257010#comment-16257010
 ] 

Chia-Ping Tsai commented on HBASE-18967:
----------------------------------------

{code}
22:10:49 | Vote |       Subsystem |  Runtime   | Comment
22:10:49 
============================================================================
22:10:49 |      |                 |            | Prechecks 
22:10:49 |  +1  |      hbaseanti  |   0m  0s   | Patch does not have any 
anti-patterns. 
22:10:49 |  +1  |        @author  |   0m  0s   | The patch does not contain any 
@author 
22:10:49 |      |                 |            | tags.
22:10:49 |  -1  |     test4tests  |   0m  0s   | The patch doesn't appear to 
include any 
22:10:49 |      |                 |            | new or modified tests. Please 
justify
22:10:49 |      |                 |            | why no new tests are needed 
for this
22:10:49 |      |                 |            | patch. Also please list what 
manual
22:10:49 |      |                 |            | steps were performed to verify 
this
22:10:49 |      |                 |            | patch.
22:10:49 |      |                 |            | branch-1.3 Compile Tests 
22:10:49 |  +1  |     mvninstall  |   1m  0s   | branch-1.3 passed 
22:10:49 |  +1  |        compile  |   0m 11s   | branch-1.3 passed 
22:10:49 |  +1  |     checkstyle  |   0m 36s   | branch-1.3 passed 
22:10:49 |  +1  |       findbugs  |   0m 32s   | branch-1.3 passed 
22:10:49 |  +1  |        javadoc  |   0m 45s   | branch-1.3 passed 
22:10:49 |      |                 |            | Patch Compile Tests 
22:10:49 |  +1  |     mvninstall  |   0m 11s   | the patch passed 
22:10:49 |  +1  |        compile  |   0m 10s   | the patch passed 
22:10:49 |  +1  |          javac  |   0m 10s   | the patch passed 
22:10:49 |  +1  |     checkstyle  |   0m 13s   | hbase-thrift: The patch 
generated 0 new 
22:10:49 |      |                 |            | + 8 unchanged - 5 fixed = 8 
total (was
22:10:49 |      |                 |            | 13)
22:10:49 |  +1  |     whitespace  |   0m  0s   | The patch has no whitespace 
issues. 
22:10:49 |  +1  |    hadoopcheck  |   9m 14s   | The patch does not cause any 
errors 
22:10:49 |      |                 |            | with Hadoop 2.4.0 2.4.1 2.5.0 
2.5.1
22:10:49 |      |                 |            | 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1.
22:10:49 |  +1  |       findbugs  |   0m 34s   | the patch passed 
22:10:49 |  +1  |        javadoc  |   0m 10s   | the patch passed 
22:10:49 |      |                 |            | Other Tests 
22:10:49 |  +1  |           unit  |   4m 59s   | hbase-thrift in the patch 
passed. 
22:10:49 |  +1  |     asflicense  |   0m 31s   | The patch does not generate 
ASF License 
22:10:49 |      |                 |            | warnings.
22:10:49 |      |                 |  19m 37s   | 
{code}
+1 on v3

> Backport HBASE-17181 to branch-1.3
> ----------------------------------
>
>                 Key: HBASE-18967
>                 URL: https://issues.apache.org/jira/browse/HBASE-18967
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Chia-Ping Tsai
>            Assignee: Peter Somogyi
>             Fix For: 1.3.2
>
>         Attachments: HBASE-18967.branch-1.3.001.patch, 
> HBASE-18967.branch-1.3.001.patch, HBASE-18967.branch-1.3.001.patch, 
> HBASE-18967.branch-1.3.001.patch, HBASE-18967.branch-1.3.001.patch, 
> HBASE-18967.branch-1.3.002.patch, HBASE-18967.branch-1.3.003.patch, 
> HBASE-18967.branch-1.3.003.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to