[ https://issues.apache.org/jira/browse/HBASE-19266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260279#comment-16260279 ]
Chia-Ping Tsai edited comment on HBASE-19266 at 11/21/17 5:51 AM: ------------------------------------------------------------------ bq. What is the running time before HBASE-19200? before: 655.004s HBASE-19200: 865.749s bq. I can see that we spend more than 1 second to retrieve the cluster id, too long I think. Will open a issue for this. The cost i observed is same with you.:) I don't think the 1 second will kill us, and we don't have to revert HBASE-19200. The root cause is that {{TestAcidGuarantees}} is a parameterized test, so any small cost will make the executed time become even larger. There are many solutions about speeding up {{TestAcidGuarantees}}. # start mini cluster once (HBASE-19311) # separate {{TestAcidGuarantees}} #1 will be addressed by [~Apache9], and it is a good solution as the initialization of mini cluster is slower than any phases. #2 is necessary also I think as it not only speed up the {{TestAcidGuarantees}} but also help us to debug for different MemStore in the future. was (Author: chia7712): bq. What is the running time before HBASE-19200? before: 655.004s HBASE-19200: 865.749s bq. I can see that we spend more than 1 second to retrieve the cluster id, too long I think. Will open a issue for this. The cost i observed is same with you.:) I don't think the 1 second will kill us, and we don't have to revert HBASE-19200. The root cause is that {{TestAcidGuarantees}} is a parameterized test, so any small cost will make the executed time become even larger. There are many solution about speeding up {{TestAcidGuarantees}}. # start mini cluster once (HBASE-19311) # separate {{TestAcidGuarantees}} #1 will be addressed by [~Apache9], and it is a good solution as the initialization of mini cluster is slower than any phases. #2 is necessary also I think as it not only speed up the {{TestAcidGuarantees}} but also help us to debug for different MemStore in the future. > TestAcidGuarantees should cover adaptive in-memory compaction > ------------------------------------------------------------- > > Key: HBASE-19266 > URL: https://issues.apache.org/jira/browse/HBASE-19266 > Project: HBase > Issue Type: Test > Reporter: Ted Yu > Priority: Minor > > Currently TestAcidGuarantees populates 3 policies of (in-memory) compaction. > Adaptive in-memory compaction is new and should be added as 4th compaction > policy. -- This message was sent by Atlassian JIRA (v6.4.14#64029)