[ https://issues.apache.org/jira/browse/HBASE-19122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16262018#comment-16262018 ]
stack commented on HBASE-19122: ------------------------------- .004 addresses checkstyle (except the import order which I have trouble making sense of) and the failing unit test; I removed the unit test since it is a test that checks mem sizing when a flush is cancelled only flushes can't be cancelled by CPs any more... > preCompact and preFlush can bypass by returning null scanner; shut it down > -------------------------------------------------------------------------- > > Key: HBASE-19122 > URL: https://issues.apache.org/jira/browse/HBASE-19122 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors, Scanners > Reporter: stack > Assignee: stack > Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19122.master.001.patch, > HBASE-19122.master.002.patch, HBASE-19122.master.003.patch, > HBASE-19122.master.004.patch > > > Noticed by [~anoop.hbase] during review of HBASE-18770, preCompact and > preFlush can bypass normal processing by returning null. They are not > bypasable by ordained route. We should shut down this avenue. > The preCompact at least may be new coming in with: > {code} > tree dbf13093842f85a713f023d7219caccf8f4eb05f > parent a4dcf51415616772e462091ce93622f070ea8810 > author zhangduo <zhang...@apache.org> Sat Apr 9 16:18:08 2016 +0800 > committer zhangduo <zhang...@apache.org> Sun Apr 10 09:26:28 2016 +0800 > HBASE-15527 Refactor Compactor related classes > {code} > Would have to dig in more to figure for sure. -- This message was sent by Atlassian JIRA (v6.4.14#64029)