[ 
https://issues.apache.org/jira/browse/HBASE-19093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16264484#comment-16264484
 ] 

Balazs Meszaros commented on HBASE-19093:
-----------------------------------------

I have started to modify the test, where I check the methods of 
{{MasterService.Interface}}. It is possible to find theirs corresponding 
methods in {{AccessController}}, but the names of some methods are different 
(e.g. {{moveRegion}} -> {{preMove}}, {{assignRegion}} -> {{preAssign}}, 
{{addColumn}} -> {{modifyTable}}, ...). I can set up some rules for these 
cases, but the test will be a little bit more complicated. This approach seems 
to be better, because for example {{setBalancerRunning}} does not call 
{{MasterObserver}} at all.

> Check Admin/Table to ensure all operations go via AccessControl
> ---------------------------------------------------------------
>
>                 Key: HBASE-19093
>                 URL: https://issues.apache.org/jira/browse/HBASE-19093
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: stack
>            Assignee: Balazs Meszaros
>            Priority: Blocker
>             Fix For: 2.0.0-beta-1
>
>         Attachments: HBASE-19093.master.001.patch, 
> HBASE-19093.master.002.patch, RegionObserver.txt
>
>
> A cursory review of Admin Interface has a bunch of methods as open, with out 
> AccessControl checks. For example, procedure executor has not check on it.
> This issue is about given the Admin and Table Interfaces a once-over to see 
> what is missing and to fill in access control where missing.
> This is a follow-on from work over in HBASE-19048



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to