[
https://issues.apache.org/jira/browse/HBASE-19325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266474#comment-16266474
]
Chia-Ping Tsai commented on HBASE-19325:
----------------------------------------
{code}
13:52:18 -1 overall
13:52:18
13:52:18 _____ _ _ _
13:52:18 | ___|_ _(_) |_ _ _ __ ___| |
13:52:18 | |_ / _` | | | | | | '__/ _ \ |
13:52:18 | _| (_| | | | |_| | | | __/_|
13:52:18 |_| \__,_|_|_|\__,_|_| \___(_)
13:52:18
13:52:18
13:52:18
13:52:18 | Vote | Subsystem | Runtime | Comment
13:52:18
============================================================================
13:52:18 | | | | Prechecks
13:52:18 | +1 | hbaseanti | 0m 0s | Patch does not have any
anti-patterns.
13:52:18 | +1 | @author | 0m 0s | The patch does not contain any
@author
13:52:18 | | | | tags.
13:52:18 | +1 | test4tests | 0m 0s | The patch appears to include 1
new or
13:52:18 | | | | modified test files.
13:52:18 | | | | branch-1 Compile Tests
13:52:18 | 0 | mvndep | 6m 1s | Maven dependency ordering for
branch
13:52:18 | +1 | mvninstall | 1m 2s | branch-1 passed
13:52:18 | +1 | compile | 0m 25s | branch-1 passed
13:52:18 | +1 | checkstyle | 0m 50s | branch-1 passed
13:52:18 | 0 | findbugs | 0m 57s | hbase-server in branch-1 has 1
extant
13:52:18 | | | | Findbugs warnings.
13:52:18 | +1 | javadoc | 0m 32s | branch-1 passed
13:52:18 | | | | Patch Compile Tests
13:52:18 | 0 | mvndep | 0m 6s | Maven dependency ordering for
patch
13:52:18 | +1 | mvninstall | 0m 29s | the patch passed
13:52:18 | +1 | compile | 0m 25s | the patch passed
13:52:18 | +1 | javac | 0m 25s | the patch passed
13:52:19 | +1 | checkstyle | 0m 37s | the patch passed
13:52:19 | +1 | whitespace | 0m 0s | The patch has no whitespace
issues.
13:52:19 | +1 | hadoopcheck | 8m 38s | The patch does not cause any
errors
13:52:19 | | | | with Hadoop 2.4.0 2.4.1 2.5.0
2.5.1
13:52:19 | | | | 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1.
13:52:19 | +1 | findbugs | 1m 17s | the patch passed
13:52:19 | +1 | javadoc | 0m 18s | the patch passed
13:52:19 | | | | Other Tests
13:52:19 | -1 | unit | 80m 29s | hbase-server in the patch
failed.
13:52:19 | +1 | unit | 3m 58s | hbase-rsgroup in the patch
passed.
13:52:19 | +1 | asflicense | 0m 19s | The patch does not generate
ASF License
13:52:19 | | | | warnings.
13:52:19 | | | 107m 21s |
13:52:19
13:52:19
13:52:19 Reason | Tests
13:52:19 Failed junit tests |
hadoop.hbase.client.TestHTableMultiplexerFlushCache
13:52:19 |
hadoop.hbase.replication.TestReplicationSmallTests
13:52:19 | hadoop.hbase.client.TestMetaWithReplicas
13:52:19 |
hadoop.hbase.regionserver.TestEndToEndSplitTransaction
13:52:19 |
hadoop.hbase.mapreduce.TestMultithreadedTableMapper
13:52:19 |
hadoop.hbase.regionserver.TestCompactionInDeadRegionServer
13:52:19
13:52:19
13:52:19 || Subsystem || Report/Notes ||
13:52:19
============================================================================
13:52:19 | Optional Tests | asflicense javac javadoc unit findbugs
hadoopcheck hbaseanti checkstyle compile |
13:52:19 | uname | Linux 2060d48154ce 4.10.0-38-generic #42-Ubuntu SMP Tue Oct
10 13:24:27 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
13:52:19 | Build tool | maven |
13:52:19 | Personality | /script/yetus/precommit/personality/hbase.sh |
13:52:19 | git revision | branch-1 / 20d811121f |
13:52:19 | maven | version: Apache Maven 3.3.9 |
13:52:19 | Default Java | 1.8.0_131 |
13:52:19 | findbugs | v3.1.0-RC1 |
13:52:19 | unit | /patchprocess/patch-unit-hbase-server.txt |
13:52:19 | modules | C: hbase-server hbase-rsgroup U: . |
13:52:19 | Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
{code}
TestCompactionInDeadRegionServer is traced by HBASE-19056.
TestMultithreadedTableMapper -> HBASE-19300
Others fail without the patch.
Will commit it tomorrow if no objections.
> Pass a list of server name to postClearDeadServers
> --------------------------------------------------
>
> Key: HBASE-19325
> URL: https://issues.apache.org/jira/browse/HBASE-19325
> Project: HBase
> Issue Type: Bug
> Affects Versions: 2.0.0-beta-2
> Reporter: Guangxu Cheng
> Assignee: Guangxu Cheng
> Fix For: 1.4.0, 2.0.0-beta-1
>
> Attachments: HBASE-19325.branch-1.001.patch,
> HBASE-19325.branch-1.001.patch, HBASE-19325.branch-2.001.patch
>
>
> Over on the tail of HBASE-18131. [~chia7712] said
> {quote}
> (Revisiting the AccessController remind me of this issue)
> Could we remove the duplicate code on the server side? Why not pass a list of
> server name to postClearDeadServers and postListDeadServers?
> {quote}
> The duplicate code has been removed in HBASE-19131.Now Pass a list of server
> name to postClearDeadServers
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
