Should a failure in creating an unassigned node abort the master?
-----------------------------------------------------------------

                 Key: HBASE-5281
                 URL: https://issues.apache.org/jira/browse/HBASE-5281
             Project: HBase
          Issue Type: Bug
          Components: master
    Affects Versions: 0.90.5
            Reporter: Harsh J
             Fix For: 0.94.0, 0.92.1


In {{AssignmentManager}}'s {{CreateUnassignedAsyncCallback}}, we have the 
following condition:

{code}
if (rc != 0) {
        // Thisis resultcode.  If non-zero, need to resubmit.
        LOG.warn("rc != 0 for " + path + " -- retryable connectionloss -- " +
          "FIX see http://wiki.apache.org/hadoop/ZooKeeper/FAQ#A2";);
        this.zkw.abort("Connectionloss writing unassigned at " + path +
          ", rc=" + rc, null);
        return;
}
{code}

While a similar structure inside {{ExistsUnassignedAsyncCallback}} (which the 
above is linked to), does not have such a force abort.

Do we really require the abort statement here, or can we make do without?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to