[ 
https://issues.apache.org/jira/browse/HBASE-19348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267297#comment-16267297
 ] 

Chia-Ping Tsai edited comment on HBASE-19348 at 11/27/17 7:20 PM:
------------------------------------------------------------------

{code}
14:34:35 -1 overall
14:34:35 
14:34:35  _____     _ _                _ 
14:34:35 |  ___|_ _(_) |_   _ _ __ ___| |
14:34:35 | |_ / _` | | | | | | '__/ _ \ |
14:34:35 |  _| (_| | | | |_| | | |  __/_|
14:34:35 |_|  \__,_|_|_|\__,_|_|  \___(_)
14:34:35                                 
14:34:35 
14:34:35 
14:34:35 | Vote |       Subsystem |  Runtime   | Comment
14:34:35 
============================================================================
14:34:35 |      |                 |            | Prechecks 
14:34:35 |  +1  |      hbaseanti  |   0m  0s   | Patch does not have any 
anti-patterns. 
14:34:35 |  +1  |        @author  |   0m  0s   | The patch does not contain any 
@author 
14:34:35 |      |                 |            | tags.
14:34:35 |  +1  |     test4tests  |   0m  0s   | The patch appears to include 
11 new or 
14:34:35 |      |                 |            | modified test files.
14:34:35 |      |                 |            | branch-1 Compile Tests 
14:34:35 |  +1  |     mvninstall  |   2m 57s   | branch-1 passed 
14:34:35 |  +1  |        compile  |   0m 37s   | branch-1 passed 
14:34:35 |  +1  |     checkstyle  |   1m 25s   | branch-1 passed 
14:34:35 |   0  |       findbugs  |   1m 58s   | hbase-server in branch-1 has 1 
extant 
14:34:35 |      |                 |            | Findbugs warnings.
14:34:35 |  +1  |        javadoc  |   0m 53s   | branch-1 passed 
14:34:35 |      |                 |            | Patch Compile Tests 
14:34:35 |  +1  |     mvninstall  |   0m 46s   | the patch passed 
14:34:35 |  +1  |        compile  |   0m 39s   | the patch passed 
14:34:35 |  +1  |          javac  |   0m 39s   | the patch passed 
14:34:35 |  -1  |     checkstyle  |   1m 10s   | hbase-server: The patch 
generated 1 new 
14:34:35 |      |                 |            | + 531 unchanged - 3 fixed = 
532 total
14:34:35 |      |                 |            | (was 534)
14:34:35 |  +1  |     whitespace  |   0m  1s   | The patch has no whitespace 
issues. 
14:34:35 |  +1  |    hadoopcheck  |  18m 20s   | The patch does not cause any 
errors 
14:34:35 |      |                 |            | with Hadoop 2.4.0 2.4.1 2.5.0 
2.5.1
14:34:35 |      |                 |            | 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1.
14:34:36 |  +1  |       findbugs  |   2m  1s   | the patch passed 
14:34:36 |  +1  |        javadoc  |   0m 28s   | the patch passed 
14:34:36 |      |                 |            | Other Tests 
14:34:36 |  -1  |           unit  | 119m 14s   | hbase-server in the patch 
failed. 
14:34:36 |  +1  |     asflicense  |   0m 48s   | The patch does not generate 
ASF License 
14:34:36 |      |                 |            | warnings.
14:34:36 |      |                 | 151m 50s   | 
14:34:36 
14:34:36 
14:34:36               Reason | Tests
14:34:36  Failed junit tests  |  
hadoop.hbase.regionserver.TestEndToEndSplitTransaction 
14:34:36                      |  
hadoop.hbase.mapreduce.TestMultithreadedTableMapper 
14:34:36                      |  
hadoop.hbase.security.visibility.TestVisibilityLabelsWithACL 
14:34:36                      |  hadoop.hbase.client.TestMetaWithReplicas 
14:34:36 
14:34:36 
14:34:36 || Subsystem || Report/Notes ||
14:34:36 
============================================================================
14:34:36 | Optional Tests |  asflicense  javac  javadoc  unit  findbugs  
hadoopcheck  hbaseanti  checkstyle  compile  |
14:34:36 | uname | Linux 79765bdf7e57 4.10.0-35-generic #39-Ubuntu SMP Wed Sep 
13 07:46:59 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
14:34:36 | Build tool | maven |
14:34:36 | Personality | /script/yetus/precommit/personality/hbase.sh |
14:34:36 | git revision | branch-1 / 20d811121f |
14:34:36 | maven | version: Apache Maven 3.3.9 |
14:34:36 | Default Java | 1.8.0_131 |
14:34:36 | findbugs | v3.1.0-RC1 |
14:34:36 | checkstyle | /patchprocess/diff-checkstyle-hbase-server.txt |
14:34:36 | unit | /patchprocess/patch-unit-hbase-server.txt |
14:34:36 | modules | C: hbase-server U: hbase-server |
14:34:36 | Powered by | Apache Yetus 0.6.0   http://yetus.apache.org |
14:34:36 
{code}
TestMultithreadedTableMapper -> HBASE-19300
Others fail without the patch.

[~apurtell] [~mdrob] Any suggestions?


was (Author: chia7712):
{code}
14:34:35 -1 overall
14:34:35 
14:34:35  _____     _ _                _ 
14:34:35 |  ___|_ _(_) |_   _ _ __ ___| |
14:34:35 | |_ / _` | | | | | | '__/ _ \ |
14:34:35 |  _| (_| | | | |_| | | |  __/_|
14:34:35 |_|  \__,_|_|_|\__,_|_|  \___(_)
14:34:35                                 
14:34:35 
14:34:35 
14:34:35 | Vote |       Subsystem |  Runtime   | Comment
14:34:35 
============================================================================
14:34:35 |      |                 |            | Prechecks 
14:34:35 |  +1  |      hbaseanti  |   0m  0s   | Patch does not have any 
anti-patterns. 
14:34:35 |  +1  |        @author  |   0m  0s   | The patch does not contain any 
@author 
14:34:35 |      |                 |            | tags.
14:34:35 |  +1  |     test4tests  |   0m  0s   | The patch appears to include 
11 new or 
14:34:35 |      |                 |            | modified test files.
14:34:35 |      |                 |            | branch-1 Compile Tests 
14:34:35 |  +1  |     mvninstall  |   2m 57s   | branch-1 passed 
14:34:35 |  +1  |        compile  |   0m 37s   | branch-1 passed 
14:34:35 |  +1  |     checkstyle  |   1m 25s   | branch-1 passed 
14:34:35 |   0  |       findbugs  |   1m 58s   | hbase-server in branch-1 has 1 
extant 
14:34:35 |      |                 |            | Findbugs warnings.
14:34:35 |  +1  |        javadoc  |   0m 53s   | branch-1 passed 
14:34:35 |      |                 |            | Patch Compile Tests 
14:34:35 |  +1  |     mvninstall  |   0m 46s   | the patch passed 
14:34:35 |  +1  |        compile  |   0m 39s   | the patch passed 
14:34:35 |  +1  |          javac  |   0m 39s   | the patch passed 
14:34:35 |  -1  |     checkstyle  |   1m 10s   | hbase-server: The patch 
generated 1 new 
14:34:35 |      |                 |            | + 531 unchanged - 3 fixed = 
532 total
14:34:35 |      |                 |            | (was 534)
14:34:35 |  +1  |     whitespace  |   0m  1s   | The patch has no whitespace 
issues. 
14:34:35 |  +1  |    hadoopcheck  |  18m 20s   | The patch does not cause any 
errors 
14:34:35 |      |                 |            | with Hadoop 2.4.0 2.4.1 2.5.0 
2.5.1
14:34:35 |      |                 |            | 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1.
14:34:36 |  +1  |       findbugs  |   2m  1s   | the patch passed 
14:34:36 |  +1  |        javadoc  |   0m 28s   | the patch passed 
14:34:36 |      |                 |            | Other Tests 
14:34:36 |  -1  |           unit  | 119m 14s   | hbase-server in the patch 
failed. 
14:34:36 |  +1  |     asflicense  |   0m 48s   | The patch does not generate 
ASF License 
14:34:36 |      |                 |            | warnings.
14:34:36 |      |                 | 151m 50s   | 
14:34:36 
14:34:36 
14:34:36               Reason | Tests
14:34:36  Failed junit tests  |  
hadoop.hbase.regionserver.TestEndToEndSplitTransaction 
14:34:36                      |  
hadoop.hbase.mapreduce.TestMultithreadedTableMapper 
14:34:36                      |  
hadoop.hbase.security.visibility.TestVisibilityLabelsWithACL 
14:34:36                      |  hadoop.hbase.client.TestMetaWithReplicas 
14:34:36 
14:34:36 
14:34:36 || Subsystem || Report/Notes ||
14:34:36 
============================================================================
14:34:36 | Optional Tests |  asflicense  javac  javadoc  unit  findbugs  
hadoopcheck  hbaseanti  checkstyle  compile  |
14:34:36 | uname | Linux 79765bdf7e57 4.10.0-35-generic #39-Ubuntu SMP Wed Sep 
13 07:46:59 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
14:34:36 | Build tool | maven |
14:34:36 | Personality | /script/yetus/precommit/personality/hbase.sh |
14:34:36 | git revision | branch-1 / 20d811121f |
14:34:36 | maven | version: Apache Maven 3.3.9 |
14:34:36 | Default Java | 1.8.0_131 |
14:34:36 | findbugs | v3.1.0-RC1 |
14:34:36 | checkstyle | /patchprocess/diff-checkstyle-hbase-server.txt |
14:34:36 | unit | /patchprocess/patch-unit-hbase-server.txt |
14:34:36 | modules | C: hbase-server U: hbase-server |
14:34:36 | Powered by | Apache Yetus 0.6.0   http://yetus.apache.org |
14:34:36 
{code}
TestMultithreadedTableMapper -> HBASE-19300
Others fail without the patch.

[~apurtell] [~mike drob Any suggestions?

> Fix error-prone errors for branch-1
> -----------------------------------
>
>                 Key: HBASE-19348
>                 URL: https://issues.apache.org/jira/browse/HBASE-19348
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>            Priority: Minor
>             Fix For: 1.4.0
>
>         Attachments: HBASE-19348.branch-1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to