[
https://issues.apache.org/jira/browse/HBASE-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16269991#comment-16269991
]
Duo Zhang commented on HBASE-18601:
-----------------------------------
Belated but what does this code mean?
{code}
@Override
public void sync(long txid) throws IOException {
if (highestSyncedTxid.get() >= txid) {
return;
}
try (TraceScope scope = TraceUtil.createTrace("AsyncFSWAL.sync")) {
// here we do not use ring buffer sequence as txid
long sequence = waitingConsumePayloads.next();
SyncFuture future = null;
try {
if (scope != null) {
future = getSyncFuture(txid, scope.getSpan());
RingBufferTruck truck = waitingConsumePayloads.get(sequence);
truck.load(future);
}
} finally {
waitingConsumePayloads.publish(sequence);
}
if (shouldScheduleConsumer()) {
consumeExecutor.execute(consumer);
}
// TODO handle htrace API change, see HBASE-18895
// scope = Trace.continueSpan(blockOnSync(future));
if (future != null) {
blockOnSync(future);
}
}
}
{code}
We will give up syncing on WAL if there is no TraceScope provided?
> Update Htrace to 4.2
> --------------------
>
> Key: HBASE-18601
> URL: https://issues.apache.org/jira/browse/HBASE-18601
> Project: HBase
> Issue Type: Improvement
> Components: dependencies, tracing
> Affects Versions: 2.0.0, 3.0.0
> Reporter: Tamas Penzes
> Assignee: Balazs Meszaros
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18601.master.001.patch,
> HBASE-18601.master.002.patch, HBASE-18601.master.003 (3).patch,
> HBASE-18601.master.003.patch, HBASE-18601.master.004.patch,
> HBASE-18601.master.004.patch, HBASE-18601.master.005.patch,
> HBASE-18601.master.006.patch, HBASE-18601.master.006.patch,
> HBASE-18601.master.007.patch, HBASE-18601.master.007.patch,
> HBASE-18601.master.007.patch, HBASE-18601.master.008.patch,
> HBASE-18601.master.009.patch, HBASE-18601.master.009.patch,
> HBASE-18601.master.010.patch, HBASE-18601.master.010.patch,
> HBASE-18601.master.011.patch, HBASE-18601.master.012.patch,
> HBASE-18601.master.013.patch, HBASE-18601.master.014.patch,
> HBASE-18601.master.014.patch, HBASE-18601.master.015.patch,
> HBASE-18601.master.016.patch
>
>
> HTrace is not perfectly integrated into HBase, the version 3.2.0 is buggy,
> the upgrade to 4.x is not trivial and would take time. It might not worth to
> keep it in this state, so would be better to remove it.
> Of course it doesn't mean tracing would be useless, just that in this form
> the use of HTrace 3.2 might not add any value to the project and fixing it
> would be far too much effort.
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> Based on the decision of the community we keep htrace now and update version
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
