[
https://issues.apache.org/jira/browse/HBASE-19056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271326#comment-16271326
]
Chia-Ping Tsai commented on HBASE-19056:
----------------------------------------
It seems the master tries do update the meta table but the first PUT is
submitted to the rs which is suspend in the test case. Hence, the failure of
wal sync for the meta region in the suspended rs will kill it self. And then
the region evaluated in the test case will be closed also if it is located at
the suspended rs.
[~tedyu]'s solution LGTM.
The another question is, should we clear the cache of meta table when Master is
trying to update the location of meta table, or to do nothing as the cache
clear will happen automatically after the submission failure?
> TestCompactionInDeadRegionServer is top of the flakies charts!
> ---------------------------------------------------------------
>
> Key: HBASE-19056
> URL: https://issues.apache.org/jira/browse/HBASE-19056
> Project: HBase
> Issue Type: Bug
> Components: test
> Reporter: stack
> Assignee: Ted Yu
> Attachments: 19056.v5.txt
>
>
> The test came in recently as part of HBASE-17712 "Remove/Simplify the logic
> of RegionScannerImpl.handleFileNotFound"
> [~Apache9] when you have a chance, help me out. I was going to just remove
> the test since it made no sense to me but then I saw you wrote it (smile).
> When the region.compact(true); is called on the end, what is supposed to be
> going on?
> When I trace, the compact is not done because the Region is not writeEnabled
> (we check if Region is writeEnabled down in Store before we go ahead and
> compact). So, I thought the problem was that the region reference was stale
> because it came from the rsToSuspend which had just been killed.
> After a while, I figured that you intend the region reference to be stale so
> you can try an append AFTER the WAL has been taken over by WAL splitter.
> But the writeEnabled flag is set so compactions don't run. I tried unsetting
> this flag and closed flags and but compaction won't run.
> Was this your intent sir? If so, I'll work w/ it np. Just looking for
> clarity. Thanks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
