[
https://issues.apache.org/jira/browse/HBASE-19188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271807#comment-16271807
]
Appy commented on HBASE-19188:
------------------------------
Pardon late review. Looking at it now after recent ping by [~psomogyi]. Just
few questions:
bq. I'm not sure if we need it for all modules. Probably adding it to the ones
that invoke ANT with JspC would be sufficient. These are hbase-server,
hbase-thrift and hbase-rest.
Is it possible to remove it from other modules altogether. They might be there
just because new modules copy-paste pom.xml from one of the existing modules.
(I too am culprit of that).
- Since it's a compile time dep in few modules now, does it mean it gets
packaged in tars? If yes, then marking it runtime in few places is useless.
Let's make it compile (which is default) at root pom?
> Build fails on branch-1 using maven-3.5.2
> -----------------------------------------
>
> Key: HBASE-19188
> URL: https://issues.apache.org/jira/browse/HBASE-19188
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 1.4.0, 1.3.1, 1.2.6, 1.5.0
> Reporter: Peter Somogyi
> Assignee: Peter Somogyi
> Priority: Blocker
> Fix For: 1.4.0, 1.3.2, 1.2.7
>
> Attachments: HBASE-19188.branch-1.2.001.patch,
> HBASE-19188.branch-1.2.002.patch
>
>
> With maven 3.5.2 the build fails on branch-1-2, branch-1.3, branch-1.4 and
> branch-1. On branch-1.1, branch-2 and master the build succeeds. With older
> maven versions the build finishes.
> {code:title=Maven version}
> $ mvn -v
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=1024m;
> support was removed in 8.0
> Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d;
> 2017-10-18T09:58:13+02:00)
> Maven home: /Users/peter.somogyi/bin/apache-maven-3.5.2
> Java version: 1.8.0_141, vendor: Oracle Corporation
> Java home:
> /Library/Java/JavaVirtualMachines/jdk1.8.0_141.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac"
> {code}
> {code}
> $ mvn clean install -DskipTests
> ...
> [INFO] --- jamon-maven-plugin:2.4.1:translate (default) @ hbase-server ---
> [INFO]
> [INFO] --- maven-antrun-plugin:1.6:run (generate) @ hbase-server ---
> [INFO] Executing tasks
> main:
> log4j:WARN No appenders could be found for logger (org.apache.jasper.JspC).
> log4j:WARN Please initialize the log4j system properly.
> log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more
> info.
> [INFO] Logging to org.slf4j.impl.MavenSimpleLogger(org.mortbay.log) via
> org.mortbay.log.Slf4jLog
> java.util.MissingResourceException: Can't find bundle for base name
> org.apache.jasper.resources.LocalStrings, locale en_US
> at
> java.util.ResourceBundle.throwMissingResourceException(ResourceBundle.java:1564)
> at java.util.ResourceBundle.getBundleImpl(ResourceBundle.java:1387)
> at java.util.ResourceBundle.getBundle(ResourceBundle.java:773)
> at org.apache.jasper.compiler.Localizer.<clinit>(Localizer.java:36)
> at
> org.apache.jasper.compiler.JspRuntimeContext.<init>(JspRuntimeContext.java:103)
> at org.apache.jasper.JspC.initServletContext(JspC.java:1242)
> at org.apache.jasper.JspC.execute(JspC.java:1103)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
> at org.apache.tools.ant.TaskAdapter.execute(TaskAdapter.java:154)
> at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291)
> at sun.reflect.GeneratedMethodAccessor122.invoke(Unknown Source)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
> at org.apache.tools.ant.Task.perform(Task.java:348)
> at org.apache.tools.ant.Target.execute(Target.java:390)
> at org.apache.tools.ant.Target.performTasks(Target.java:411)
> at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1397)
> at org.apache.tools.ant.Project.executeTarget(Project.java:1366)
> at
> org.apache.maven.plugin.antrun.AntRunMojo.execute(AntRunMojo.java:270)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.executeForkedExecutions(MojoExecutor.java:353)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:198)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:309)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:194)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:107)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:955)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:290)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:194)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Apache HBase ....................................... SUCCESS [ 1.952
> s]
> [INFO] Apache HBase - Checkstyle .......................... SUCCESS [ 0.499
> s]
> [INFO] Apache HBase - Resource Bundle ..................... SUCCESS [ 0.164
> s]
> [INFO] Apache HBase - Annotations ......................... SUCCESS [ 0.798
> s]
> [INFO] Apache HBase - Protocol ............................ SUCCESS [ 8.456
> s]
> [INFO] Apache HBase - Common .............................. SUCCESS [ 4.961
> s]
> [INFO] Apache HBase - Procedure ........................... SUCCESS [ 1.242
> s]
> [INFO] Apache HBase - Metrics API ......................... SUCCESS [ 0.599
> s]
> [INFO] Apache HBase - Hadoop Compatibility ................ SUCCESS [ 0.748
> s]
> [INFO] Apache HBase - Metrics Implementation .............. SUCCESS [ 0.687
> s]
> [INFO] Apache HBase - Hadoop Two Compatibility ............ SUCCESS [ 1.217
> s]
> [INFO] Apache HBase - Client .............................. SUCCESS [ 3.575
> s]
> [INFO] Apache HBase - Prefix Tree ......................... SUCCESS [ 0.990
> s]
> [INFO] Apache HBase - Server .............................. FAILURE [ 16.050
> s]
> [INFO] Apache HBase - Testing Util ........................ SKIPPED
> [INFO] Apache HBase - Thrift .............................. SKIPPED
> [INFO] Apache HBase - Rest ................................ SKIPPED
> [INFO] Apache HBase - RSGroup ............................. SKIPPED
> [INFO] Apache HBase - Shell ............................... SKIPPED
> [INFO] Apache HBase - Integration Tests ................... SKIPPED
> [INFO] Apache HBase - Examples ............................ SKIPPED
> [INFO] Apache HBase - External Block Cache ................ SKIPPED
> [INFO] Apache HBase - Assembly ............................ SKIPPED
> [INFO] Apache HBase - Shaded .............................. SKIPPED
> [INFO] Apache HBase - Shaded - Client ..................... SKIPPED
> [INFO] Apache HBase - Shaded - Server ..................... SKIPPED
> [INFO] Apache HBase Shaded Packaging Invariants ........... SKIPPED
> [INFO] Apache HBase - Archetypes .......................... SKIPPED
> [INFO] Apache HBase - Exemplar for hbase-client archetype . SKIPPED
> [INFO] Apache HBase - Exemplar for hbase-shaded-client archetype SKIPPED
> [INFO] Apache HBase - Archetype builder ................... SKIPPED
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time: 42.875 s
> [INFO] Finished at: 2017-11-06T14:00:15+01:00
> [INFO] Final Memory: 123M/1802M
> [INFO]
> ------------------------------------------------------------------------
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-antrun-plugin:1.6:run (generate) on project
> hbase-server: An Ant BuildException has occured:
> java.lang.NullPointerException -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> [ERROR]
> [ERROR] After correcting the problems, you can resume the build with the
> command
> [ERROR] mvn <goals> -rf :hbase-server
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
