[
https://issues.apache.org/jira/browse/HBASE-19356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273374#comment-16273374
]
Appy commented on HBASE-19356:
------------------------------
Exactly. Few additional thoughts.
bq. RegionScanner postScannerOpen(ObserverContext<RegionCoprocessorEnvironment>
c, Scan scan, RegionScanner s) ->
RegionScannerDelegator
postScannerOpen(ObserverContext<RegionCoprocessorEnvironment> c, Scan scan,
RegionScanner s)
Since RegionScannerDelegator will extend RegionScanner, we don't need to change
our methods...which is great!
bq. So the CP contact itself says it clearly that the hook allows the user wrap
the original object. Not create a fresh new RegionScanner impl ignoring the one
core created
We can give links to our delegators in javadocs for those functions saying that
there are Foo set of classes to help you wrap stuff.
> Provide delegators and base implementation for Phoenix implemented interfaces
> -----------------------------------------------------------------------------
>
> Key: HBASE-19356
> URL: https://issues.apache.org/jira/browse/HBASE-19356
> Project: HBase
> Issue Type: Improvement
> Reporter: James Taylor
>
> Many of the changes Phoenix needs to make for various branches to support
> different versions of HBase are due to new methods being added to interfaces.
> Often times Phoenix can use a noop or simply needs to add the new method to
> it's delegate implementor. It'd be helpful if HBase provided base
> implementations and delegates that Phoenix could use instead. Here are some
> that come to mind:
> - RegionScanner
> - HTableInterface (Table interface now?)
> - RegionObserver
> There are likely others that [~rajeshbabu], [[email protected]], and
> [~elserj] would remember.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
