[
https://issues.apache.org/jira/browse/HBASE-19411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16275980#comment-16275980
]
Mike Drob commented on HBASE-19411:
-----------------------------------
{code}
+ MetricsSystem metricsSys = DefaultMetricsSystem.instance();
+ if (metricsSys == null) {
{code}
Why not check the result directly? We don't use it for anything else.
> HBase should not override the Metrics System prefix if one exists already
> -------------------------------------------------------------------------
>
> Key: HBASE-19411
> URL: https://issues.apache.org/jira/browse/HBASE-19411
> Project: HBase
> Issue Type: Bug
> Reporter: Haibo Chen
> Assignee: Ted Yu
> Attachments: 19411.v1.txt
>
>
> Currently the following code in BaseSourceImpl is executed unconditionally:
> {code}
> MetricsSystem metricsSys = DefaultMetricsSystem.instance();
> {code}
> As [~haibo.chen] pointed out in HBASE-19409, this would override the Metrics
> System prefix for the one NM has set up previously.
> This issue is to avoid such override.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
