[jira] [Commented] (HBASE-17123) Add postBulkLoadHFile variant that notifies the final paths for the hfiles

[Anoop Sam John (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HBASE-17123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16277123#comment-16277123
 ] 

Anoop Sam John commented on HBASE-17123:
----------------------------------------

{code}
if (region.getCoprocessorHost() != null) {
          region.getCoprocessorHost().preBulkLoadHFile(familyPaths);
        }
        try {
          map = region.bulkLoadHFiles(familyPaths, request.getAssignSeqNum(), 
null,
              request.getCopyFile());
          if (map != null) {
            loaded = true;
          }
        } finally {
          if (region.getCoprocessorHost() != null) {
            loaded = region.getCoprocessorHost().postBulkLoadHFile(familyPaths, 
map, loaded);
          }
        }
....
if (map != null) {
        loaded = true;
      }
      builder.setLoaded(loaded);
{code}

Any way that set of boolean as per post hook return looks of no use as per 
master/2.0 code. Ya that is what u r saying in above comment anyway.  IMHO the 
return boolean of post hook itself is of no use when the bulk loading was 
actually over by that time.

> Add postBulkLoadHFile variant that notifies the final paths for the hfiles
> --------------------------------------------------------------------------
>
>                 Key: HBASE-17123
>                 URL: https://issues.apache.org/jira/browse/HBASE-17123
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>              Labels: bulkloader
>             Fix For: 2.0.0
>
>         Attachments: 17123.addendum, 17123.v1.txt, 17123.v3.txt, 
> 17123.v4.txt, 17123.v5.txt
>
>
> Currently the postBulkLoadHFile() hook passes the same familyPaths parameter 
> which it receives as method parameter.
> See code in SecureBulkLoadManager :
> {code}
>        loaded = region.getCoprocessorHost().postBulkLoadHFile(familyPaths, 
> loaded);
> {code}
> Meaning, the paths are not final, moved paths of the loaded hfiles.
> This issue is to add a variant which notifies the final paths of the loaded 
> hfiles.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)