[ 
https://issues.apache.org/jira/browse/HBASE-19417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16277416#comment-16277416
 ] 

Ted Yu commented on HBASE-19417:
--------------------------------

Failed test was not related to the patch:
{code}
[ERROR] Error occurred in starting fork, check output in log
[ERROR] Process Exit Code: 1
[ERROR] Crashed tests:
[ERROR] org.apache.hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush
[ERROR]         at 
org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:686)
{code}

> Properly assign loaded flag in RSRpcServices#bulkLoadHFile()
> ------------------------------------------------------------
>
>                 Key: HBASE-19417
>                 URL: https://issues.apache.org/jira/browse/HBASE-19417
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Appy
>            Assignee: Ted Yu
>         Attachments: 19417.v1.txt, 19417.v2.txt
>
>
> See the discussion at the tail of HBASE-17123 where Appy pointed out that the 
> override of loaded should be placed inside else block:
> {code}
>       } else {
>         // secure bulk load
>         map = regionServer.secureBulkLoadManager.secureBulkLoadHFiles(region, 
> request);
>       }
>       BulkLoadHFileResponse.Builder builder = 
> BulkLoadHFileResponse.newBuilder();
>       if (map != null) {
>         loaded = true;
>       }
> {code}
> This issue is to address the review comment.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to