[ 
https://issues.apache.org/jira/browse/HBASE-11409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281064#comment-16281064
 ] 

Ted Yu commented on HBASE-11409:
--------------------------------

{code}
+    System.err.println("usage: " + NAME + " /path/to/hfileoutputformat-output 
tablename <depth>" + "\n -D" +
{code}
Can you use a new parameter (with hyphen) for the depth ?
The above implies that depth is required parameter.
{code}
+      if (depth < 2 || depth > 3) {
{code}
Add comment on why only two values are accepted.
{code}
+          -- regionDir
+         -- familyDir
+           -- storeFileDir
{code}
nit: adjust indentation for line chart.
{code}
+    if (preCreateTable) {
+      runTest(testName + 2, TABLE_WITHOUT_NS, bloomType, true, tableSplitKeys, 
hfileRanges,
{code}
Why govern the execution of runTest() by preCreateTable ?


> Add more flexibility for input directory structure to LoadIncrementalHFiles
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-11409
>                 URL: https://issues.apache.org/jira/browse/HBASE-11409
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: churro morales
>            Assignee: churro morales
>         Attachments: HBASE-11409.v1.patch
>
>
> Use case:
> We were trying to combine two very large tables into a single table.  Thus we 
> ran jobs in one datacenter that populated certain column families and another 
> datacenter which populated other column families.  Took a snapshot and 
> exported them to their respective datacenters.  Wanted to simply take the 
> hdfs restored snapshot and use LoadIncremental to merge the data.  
> It would be nice to add support where we could run LoadIncremental on a 
> directory where the depth of store files is something other than two (current 
> behavior).  
> With snapshots it would be nice if you could pass a restored hdfs snapshot's 
> directory and have the tool run.  
> I am attaching a patch where I parameterize the bulkLoad timeout as well as 
> the default store file depth.  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to