[ https://issues.apache.org/jira/browse/HBASE-5297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195436#comment-13195436 ]
Hadoop QA commented on HBASE-5297: ---------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12512286/HBASE-5297.D1509.2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated -140 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 161 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.TestAtomicOperation org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat org.apache.hadoop.hbase.io.hfile.TestLruBlockCache org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.io.hfile.TestHFileBlock org.apache.hadoop.hbase.mapreduce.TestImportTsv Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/862//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/862//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/862//console This message is automatically generated. > Update metrics numOpenConnections and callQueueLen directly in HBaseServer > -------------------------------------------------------------------------- > > Key: HBASE-5297 > URL: https://issues.apache.org/jira/browse/HBASE-5297 > Project: HBase > Issue Type: Improvement > Components: metrics > Reporter: Scott Chen > Assignee: Scott Chen > Priority: Minor > Fix For: 0.94.0 > > Attachments: HBASE-5297.D1509.1.patch, HBASE-5297.D1509.2.patch, > HBASE-5297.D1509.3.patch > > > It's better to directly update the metrics outside HBaseRpcMetrics so that > HBaseRpcMetrics doesn't have to hold reference to HBaseServer. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira