[jira] [Commented] (HBASE-12444) Total number of requests overflow because it's int

[Chia-Ping Tsai (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HBASE-12444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281638#comment-16281638
 ] 

Chia-Ping Tsai commented on HBASE-12444:
----------------------------------------

{code}
diff --git 
a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
 
b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
index 21a09a73e8..192c2e9ec5 100644
--- 
a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
+++ 
b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
@@ -1309,7 +1309,7 @@ public class HRegionServer extends HasThread implements
 
     ClusterStatusProtos.ServerLoad.Builder serverLoad = 
ClusterStatusProtos.ServerLoad.newBuilder();
     serverLoad.setNumberOfRequests((int) 
regionServerWrapper.getRequestsPerSecond());
-    serverLoad.setTotalNumberOfRequests((int) 
regionServerWrapper.getTotalRequestCount());
+    
serverLoad.setTotalNumberOfRequests(regionServerWrapper.getTotalRequestCount());
     serverLoad.setUsedHeapMB((int)(usedMemory / 1024 / 1024));
     serverLoad.setMaxHeapMB((int) (maxMemory / 1024 / 1024));
     Set<String> coprocessors = 
getWAL(null).getCoprocessorHost().getCoprocessors();
{code}

> Total number of requests overflow because it's int
> --------------------------------------------------
>
>                 Key: HBASE-12444
>                 URL: https://issues.apache.org/jira/browse/HBASE-12444
>             Project: HBase
>          Issue Type: Bug
>          Components: hbck, master, regionserver
>            Reporter: yunjiong zhao
>            Assignee: Chia-Ping Tsai
>            Priority: Minor
>             Fix For: 2.0.0-beta-1
>
>         Attachments: HBASE-12444.v0.patch, hbase-12444-v1.patch, 
> hbase-12444.patch
>
>
> When running hbck, I noticed "Number of requests" was wrong:
> Average load: 466.41237113402065
> Number of requests: -1835941345
> Number of regions: 45242
> Number of regions in transition: 0
> The root cause is it use int, and clearly it overflowed.
> I'll update a patch later.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)