[
https://issues.apache.org/jira/browse/HBASE-19369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16282962#comment-16282962
]
Mike Drob commented on HBASE-19369:
-----------------------------------
{code}
+ DFSTestUtil.enableAllECPolicies(cluster.getFileSystem());
{code}
That's a pretty good looking test, I'm glad you were able to find a nice
all-in-one DFSTestUtil method for this.
We might need to add in some additional check to only call that method if we're
on a version of DFS that supports it. Probably more reflection...
In {{ProtobufLogWriter}} you put a conditional check around the call to
{{CommonFSUtils.createHelper}}, but that method has it's own conditional
already. I don't think we need the double test.
It doesn't look like we need the {{Progressable}} in {{createHelper}}.
In {{AsyncFSOutputHelper}} we handle the {{create}} case, but not the
{{createNonRecursive}} case - I think we need to take care of both.
> HBase Should use Builder Pattern to Create Log Files while using WAL on
> Erasure Coding
> --------------------------------------------------------------------------------------
>
> Key: HBASE-19369
> URL: https://issues.apache.org/jira/browse/HBASE-19369
> Project: HBase
> Issue Type: Bug
> Affects Versions: 2.0.0
> Reporter: Alex Leblang
> Assignee: Alex Leblang
> Attachments: HBASE-19369.master.001.patch,
> HBASE-19369.master.002.patch
>
>
> Right now an HBase instance using the WAL won't function properly in an
> Erasure Coded environment. We should change the following line to use the
> hdfs.DistributedFileSystem builder pattern
> https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogWriter.java#L92
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
