[
https://issues.apache.org/jira/browse/HBASE-19134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284583#comment-16284583
]
Hudson commented on HBASE-19134:
--------------------------------
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4192 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/4192/])
HBASE-19134 Make WALKey an Interface; expose Read-Only version to CPs (stack:
rev a5a77ae3d5bfef9396b6024ec723d83a911692ec)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/ReplicationProtbufUtil.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALUtil.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestWALLockup.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/ClusterMarkingEntryFilter.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AsyncProtobufLogWriter.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorMetrics.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALKey.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WAL.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/FaultyProtobufLogReader.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationWALEntryFilters.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SequenceId.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/wal/WALPerformanceEvaluation.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollingNoCluster.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSWALEntry.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionReplayEvents.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestWALEntryStream.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollAbort.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALActionsListener.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestFSHLogProvider.java
* (edit)
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestWALRecordReader.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/wal/FaultyFSLog.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSource.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestRegionReplicaReplicationEndpointNoMaster.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestWALObserver.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALActionsListener.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogWriter.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALReaderOnSecureWAL.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/Replication.java
* (add) hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALKeyImpl.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AsyncFSWAL.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALRootDir.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALEdit.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/AbstractTestWALReplay.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestSecureWAL.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSourceManager.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityReplicationEndpoint.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALFactory.java
* (edit)
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSmallTests.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/DisabledWALProvider.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALSplit.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/AbstractTestProtobufLog.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/AbstractTestFSWAL.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestRegionReplicaReplicationEndpoint.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkLoad.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ReaderBase.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALMethods.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogReader.java
> Make WALKey an Interface; expose Read-Only version to CPs
> ---------------------------------------------------------
>
> Key: HBASE-19134
> URL: https://issues.apache.org/jira/browse/HBASE-19134
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, wal
> Reporter: stack
> Assignee: stack
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19134.master.001.patch,
> HBASE-19134.master.002.patch, HBASE-19134.master.003.patch,
> HBASE-19134.master.004.patch, HBASE-19134.master.005.patch
>
>
> WALKey has been made IA.Private in hbase2. Even so, given we don't have an
> alternative to expose at this time, it is exposed to coprocessors still at a
> few (now deprecated) locations.
> In review of HBASE-18770, [~chia7712] makes reasonable suggestion that what
> we expose to CPs be a read-only WALKey. He gets pushback on doing this for
> hbase2 (Do we even want to expose WALKey to CPs, is WALKey right going
> forward, etc.). Chia-Ping comes back w/ the below (copied from HBASE-18770):
> What we want to fix for WALKey are shown below.
> * expose some methods to CP user safety
> * refactor/redo
> As I see it, adding an interface exposed to CP user for WALKey is a right
> choice because it can bring some benefit.
> * We can expose part of WALKey's methods to CP users - a read-only interface
> or an interface with some modifiable setting.
> * The related CP hooks won't be deprecated
> * Doing the refactor for WALKey doesn't essentially impact the CP hook after
> 2.0 release.
> Although, it will be better to redo WALKey before 2.0 release. In short, I
> think it warrants such an interface.
> (We both agree this would be a load of work given WALKey is written to
> HFiles. Warrants a look though).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
