[
https://issues.apache.org/jira/browse/HBASE-5186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196236#comment-13196236
]
Phabricator commented on HBASE-5186:
------------------------------------
tedyu has commented on the revision "HBASE-5186 [jira] Add metrics to
ThriftServer".
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/thrift/CallQueue.java:67 Should we
consider startTime when performing equality check ?
src/main/java/org/apache/hadoop/hbase/thrift/CallQueue.java:77 Same comment
as above: include startTime in hash code ?
src/main/java/org/apache/hadoop/hbase/thrift/CallQueue.java:34 The class is
CallQueue. Should we tighten the type parameter to Call ?
The reasoning is that users of CallQueue should use offer(), put(), etc to
insert Runnable's and these methods wrap the Runnable in Call already.
That way we can save instanceof checks.
REVISION DETAIL
https://reviews.facebook.net/D1461
> Add metrics to ThriftServer
> ---------------------------
>
> Key: HBASE-5186
> URL: https://issues.apache.org/jira/browse/HBASE-5186
> Project: HBase
> Issue Type: Improvement
> Reporter: Scott Chen
> Assignee: Scott Chen
> Attachments: HBASE-5186.D1461.1.patch, HBASE-5186.D1461.2.patch,
> HBASE-5186.D1461.3.patch, HBASE-5186.D1461.4.patch, HBASE-5186.D1461.5.patch,
> HBASE-5186.D1461.6.patch
>
>
> It will be useful to have some metrics (queue length, waiting time,
> processing time ...) similar to Hadoop RPC server. This allows us to monitor
> system health also provide a tool to diagnose the problem where thrift calls
> are slow.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
