[ 
https://issues.apache.org/jira/browse/HBASE-18352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16288505#comment-16288505
 ] 

stack commented on HBASE-18352:
-------------------------------

This is an interesting issue. It depends on HBASE_18946 but apart from that 
this test turned up some interesting items:

 # On shutdown, we used to try and have Master go down last. We lost that 
facility adding in AMv2.
 # On shutdown, RS runs close of all regions its carrying. Part of close 
handling is updating the Master about the close. The Master didn't initiate the 
close as is usually the case so it doesn't know what to do w/ the incoming 
unaccounted-for close. I could notice cluster is going down and then go update 
meta... but that could be a pain given cluster is going down epecially if 1M 
regions on cluster.
 # On startup, if meta has region states as OPEN -- as would be the case here 
when the RS did the close and not the Master -- then we presumed it a crash 
down when it wasn't. Meant we lost old assignments across a restart.

So, let me put up a patch here that addresses above (though depends on 
HBASE-18946 going in first).

> Enable 
> TestMasterOperationsForRegionReplicas#testCreateTableWithMultipleReplicas 
> disabled by Proc-V2 AM in HBASE-14614
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-18352
>                 URL: https://issues.apache.org/jira/browse/HBASE-18352
>             Project: HBase
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.0.0-alpha-1
>            Reporter: Stephen Yuan Jiang
>            Assignee: huaxiang sun
>             Fix For: 2.0.0-beta-1
>
>         Attachments: HBASE-18946_1.patch
>
>
> The following replica tests were disabled by Core Proc-V2 AM in HBASE-14614:
> - Disabled parts of...testCreateTableWithMultipleReplicas in 
> TestMasterOperationsForRegionReplicas There is an issue w/ assigning more 
> replicas if number of replicas is changed on us. See '/* DISABLED!!!!! FOR 
> NOW!!!!'.
> ** NOTE We moved fixing of the below two tests out to HBASE-19268
> - Disabled testRegionReplicasOnMidClusterHighReplication in 
> TestStochasticLoadBalancer2
> - Disabled testFlushAndCompactionsInPrimary in TestRegionReplicas
> This JIRA tracks the work to enable them (or modify/remove if not applicable).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to