[
https://issues.apache.org/jira/browse/HBASE-18838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16291318#comment-16291318
]
Appy edited comment on HBASE-18838 at 12/14/17 7:06 PM:
--------------------------------------------------------
bq. v3: Moving hadoop-minicluster to test scope fixes most everything else
(*)
Guessing hadoop got rid of htrace-core from their deps too and that testing
against hadoop3 passes locally (?)
Few minor things:
- patch is adding lines with 0 indent. (i)
- Since you introduced shaded.prefix ((y)), let's replace old redundancies with
it too.
{quote}
- <artifactId>servlet-api</artifactId>
+ <artifactId>javax.servlet-api</artifactId>
{quote}
Add a separate exclusion, jic.
Or verify that this doesn't add servlet-api jar to tars. Although not an issue
right now since we build against 2.7 for release (right(?)), might surface when
2.x goes away.
(Edit: ref HBASE-19349)
(festive time, enjoy the colors :) )
was (Author: appy):
bq. v3: Moving hadoop-minicluster to test scope fixes most everything else
(*)
Guessing hadoop got rid of htrace-core from their deps too and that testing
against hadoop3 passes locally (?)
Few minor things:
- patch is adding lines with 0 indent. (i)
- Since you introduced shaded.prefix ((y)), let's replace old redundancies with
it too.
{quote}
- <artifactId>servlet-api</artifactId>
+ <artifactId>javax.servlet-api</artifactId>
{quote}
Add a separate exclusion, jic.
Or verify that this doesn't add servlet-api jar to tars. Although not an issue
right now since we build against 2.7 for release (right(?)), might surface when
2.x goes away.
(festive time, enjoy the colors :) )
> shaded artifacts are incorrect when built against hadoop 3
> ----------------------------------------------------------
>
> Key: HBASE-18838
> URL: https://issues.apache.org/jira/browse/HBASE-18838
> Project: HBase
> Issue Type: Bug
> Components: Client
> Affects Versions: 2.0.0-alpha-3
> Reporter: Sean Busbey
> Assignee: Mike Drob
> Priority: Critical
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18838-WIP.v2.patch, HBASE-18838.WIP.patch,
> HBASE-18838.v3.patch
>
>
> Building master/branch-2 against the hadoop-3 profile results in
> check-invariants screaming about unrelocated dependencies. will list details
> in comment.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
