[
https://issues.apache.org/jira/browse/HBASE-19527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293659#comment-16293659
]
Appy commented on HBASE-19527:
------------------------------
bq. Making the threads it runs be daemon seems fine but there may be some
assumptions we're breaking w/ this change
That was my biggest concern too. If a clean shutdown meant letting worker
threads check for server status at fixed safe/check points and quitting by
themselves, that would no longer happen now. They would abruptly end even for a
clean server shutdown.
For the case of server crash, they would have abruptly ended anyways, so all
necessary recovery should already be in place.
So all boils down to: Is it fine to abruptly quit whatever work these threads
are doing in case of a clean shutdown?
You mentioned region open/close. Those are regulated by master and RS are
supposed to explicitly ack back success. So abruptly ending them should be fine
(since master would detect lack of ack and take actions).
What other cases?
> Make ExecutorService threads daemon=true.
> -----------------------------------------
>
> Key: HBASE-19527
> URL: https://issues.apache.org/jira/browse/HBASE-19527
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Attachments: HBASE-19527.master.001.patch,
> HBASE-19527.master.001.patch, HBASE-19527.master.001.patch
>
>
> Let me try this. ExecutorService runs OPENs, CLOSE, etc. If Server is going
> down, no point in these threads sticking around (I think). Let me try this.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
