[ 
https://issues.apache.org/jira/browse/HBASE-19534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16294001#comment-16294001
 ] 

Ted Yu commented on HBASE-19534:
--------------------------------

lgtm

In master branch, the preStoreScannerOpen() no longer returns scanner in 
RegionObserver.java 

> Document risks of RegionObserver.preStoreScannerOpen
> ----------------------------------------------------
>
>                 Key: HBASE-19534
>                 URL: https://issues.apache.org/jira/browse/HBASE-19534
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>         Attachments: 19534-0.98.txt
>
>
> We just had an outage because we used preStoreScannerOpen, which, in our 
> case, created a new StoreScanner. In HBase versions before 1.3 this caused a 
> definite memory leak, a reference to the old StoreScanner (if not null) would 
> be held by the store until the region is closed.
> The 1.3 and later there's no such leak, but still the old scanner is not 
> properly closed.
> This should be added to the Javadoc and the ZooKeeperScanPolicyObserver 
> example should be fixed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to