[
https://issues.apache.org/jira/browse/HBASE-19549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16295168#comment-16295168
]
Chia-Ping Tsai commented on HBASE-19549:
----------------------------------------
LGTM. There is a similar issue in our production code. fix it in this jira?
{code:title=TableMapReduceUtil.java}
private static Path findOrCreateJar(Class<?> my_class, FileSystem fs,
Map<String, String> packagedClasses)
throws IOException {
// attempt to locate an existing jar for the class.
String jar = findContainingJar(my_class, packagedClasses);
if (null == jar || jar.isEmpty()) {
jar = getJar(my_class);
updateMap(jar, packagedClasses);
}
if (null == jar || jar.isEmpty()) {
return null;
}
LOG.debug(String.format("For class %s, using jar %s", my_class.getName(),
jar));
return new Path(jar).makeQualified(fs); // here
}
{code}
> Change path comparison in CommonFSUtils
> ---------------------------------------
>
> Key: HBASE-19549
> URL: https://issues.apache.org/jira/browse/HBASE-19549
> Project: HBase
> Issue Type: Bug
> Reporter: Peter Somogyi
> Assignee: Peter Somogyi
> Attachments: HBASE-19549.master.001.patch
>
>
> CommonFSUtils had a reference comparison in isValidWALRootDir. It was changed
> to equals and [~stack] recommended to use Path:makeQualified.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
