[ 
https://issues.apache.org/jira/browse/HBASE-19551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Toshihiro Suzuki updated HBASE-19551:
-------------------------------------
    Description: 
Currently, in HBaseFsck#checkRegionBoundaries(), it seems like keys from 
reader.getFirstKey() and reader.getLastKey() are directly compared by 
ByteArrayComparator:

https://github.com/apache/hbase/blob/9d0c7c6dfbcba0907cbbc2244eac570fcc4d58a5/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java#L864-L865
https://github.com/apache/hbase/blob/9d0c7c6dfbcba0907cbbc2244eac570fcc4d58a5/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java#L869-L870

This is not correct because the keys consist of a key length and key itself. We 
should compare rowkeys or the only key itself (by removing a key length).

  was:
Currently, in HBaseFsck#checkRegionBoundaries(), it seems like keys from 
reader.getFirstKey() and reader.getLastKey() are directly compared by 
ByteArrayComparator:

https://github.com/apache/hbase/blob/9d0c7c6dfbcba0907cbbc2244eac570fcc4d58a5/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java#L864-L865
https://github.com/apache/hbase/blob/9d0c7c6dfbcba0907cbbc2244eac570fcc4d58a5/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java#L864-L865

This is not correct because the keys consist of a key length and key itself. We 
should compare rowkeys or the only key itself (by removing a key length).


> hbck -boundaries doesn't work correctly
> ---------------------------------------
>
>                 Key: HBASE-19551
>                 URL: https://issues.apache.org/jira/browse/HBASE-19551
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Toshihiro Suzuki
>            Assignee: Toshihiro Suzuki
>
> Currently, in HBaseFsck#checkRegionBoundaries(), it seems like keys from 
> reader.getFirstKey() and reader.getLastKey() are directly compared by 
> ByteArrayComparator:
> https://github.com/apache/hbase/blob/9d0c7c6dfbcba0907cbbc2244eac570fcc4d58a5/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java#L864-L865
> https://github.com/apache/hbase/blob/9d0c7c6dfbcba0907cbbc2244eac570fcc4d58a5/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java#L869-L870
> This is not correct because the keys consist of a key length and key itself. 
> We should compare rowkeys or the only key itself (by removing a key length).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to