[
https://issues.apache.org/jira/browse/HBASE-19532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-19532:
---------------------------
Attachment: 19532.v3.txt
Patch v3 keeps the deterministic order of the AssignProcedure's added in the
List (in one test).
I introduced a flag which controls whether the AssignProcedure's added in the
List should be shuffled before sort is called.
If the assertion fails for any reason, the AssignProcedure's in the List would
be logged - this would facilitate future debugging.
> AssignProcedure#COMPARATOR may produce incorrect sort order
> -----------------------------------------------------------
>
> Key: HBASE-19532
> URL: https://issues.apache.org/jira/browse/HBASE-19532
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Critical
> Fix For: 2.0.0-beta-1
>
> Attachments: 19532.v1.txt, 19532.v2.txt, 19532.v3.txt
>
>
> The intention of AssignProcedure#COMPARATOR is to put the regions in the
> following order:
> meta regions
> system table regions
> user table regions
> However, the current implementation may produce incorrect sort order.
> With the modified test, the test fails with:
> {code}
> testComparatorWithMetas(org.apache.hadoop.hbase.master.snapshot.TestAssignProcedure)
> Time elapsed: 0.038 sec <<< FAILURE!
> junit.framework.AssertionFailedError
> at
> org.apache.hadoop.hbase.master.snapshot.TestAssignProcedure.testComparatorWithMetas(TestAssignProcedure.java:88)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
