[ 
https://issues.apache.org/jira/browse/HBASE-19553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16296862#comment-16296862
 ] 

Ted Yu commented on HBASE-19553:
--------------------------------

lgtm
{code}
4449    
4450        // Remove parent's replica regions from AM's memory
4451        for (List<HRegionInfo> l : c) {
4452          for (HRegionInfo h : l) {
4453            if (!RegionReplicaUtil.isDefaultReplica(h)) {
4454              regionStates.deleteRegion(h);
4455            }
4456          }
4457        }
{code}
You can extract the above into a private method which is called in the two 
places.

> Old replica regions should be cleared from AM memory after primary region 
> split or merge
> ----------------------------------------------------------------------------------------
>
>                 Key: HBASE-19553
>                 URL: https://issues.apache.org/jira/browse/HBASE-19553
>             Project: HBase
>          Issue Type: Bug
>          Components: master
>            Reporter: huaxiang sun
>            Assignee: Pankaj Kumar
>            Priority: Minor
>             Fix For: 1.5.0
>
>         Attachments: HBASE-19553-branch-1.patch
>
>
> Similar to HBASE-18025, the replica parent's info is not removed from master. 
> Actually I think it can be removed after replica region is split or merged, I 
> will check the logic and apply one patch.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to