[
https://issues.apache.org/jira/browse/HBASE-19556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16297336#comment-16297336
]
Ted Yu commented on HBASE-19556:
--------------------------------
+1
> Remove TestAssignmentManager#testGoodSplit, which no longer make sense
> ----------------------------------------------------------------------
>
> Key: HBASE-19556
> URL: https://issues.apache.org/jira/browse/HBASE-19556
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 2.0.0
> Reporter: Yi Liang
> Assignee: Yi Liang
> Priority: Minor
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19556-master-v1.patch
>
>
> {quote}
> [ERROR]
> testGoodSplit(org.apache.hadoop.hbase.master.assignment.TestAssignmentManager)
> Time elapsed: 0.478 s <<< ERROR!
> java.io.IOException: 5a50732f7cb3a05dd3a297bacbc34943 NOT splittable
> {quote}
> GoodSplitExecutor can only mock some functions in RSProcedureDispatcher,
> however, to test split, we need to create(or mock) a real table on region
> server side. And GoodSplitExecutor can not mock those kinds of function.
> And, similar test has already been covered in TestSplitTableRegionProcedure,
> we no longer need to test it again in TestAssignmentManager
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
