[
https://issues.apache.org/jira/browse/HBASE-4542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197439#comment-13197439
]
Phabricator commented on HBASE-4542:
------------------------------------
stack has commented on the revision "[jira] [HBASE-4542] Add filter info to
slow query logging".
+1
Some small comments.
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/filter/FilterBase.java:146 Should the
subclasses call this and then decorate what this returns with the filter
subclass specifics? Otherwise you have this repeating of
this.getClass().getSimpleName() in each subclass toString. No biggie, just a
thought.
src/main/java/org/apache/hadoop/hbase/filter/FilterList.java:317 Why we do
this? The toString is not being allowed actual filter list size?
src/main/java/org/apache/hadoop/hbase/filter/MultipleColumnPrefixFilter.java:143
Yeah, I don't get this constraining upper bound.
REVISION DETAIL
https://reviews.facebook.net/D1539
> add filter info to slow query logging
> -------------------------------------
>
> Key: HBASE-4542
> URL: https://issues.apache.org/jira/browse/HBASE-4542
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.89.20100924
> Reporter: Kannan Muthukkaruppan
> Assignee: Madhuwanti Vaidya
> Attachments: D1263.2.patch, D1539.1.patch
>
>
> Slow query log doesn't report filters in effect.
> For example:
> {code}
> (operationTooSlow): \
> {"processingtimems":3468,"client":"10.138.43.206:40035","timeRange":
> [0,9223372036854775807],\
> "starttimems":1317772005821,"responsesize":42411, \
> "class":"HRegionServer","table":"myTable","families":{"CF1":"ALL"]},\
> "row":"6c3b8efa132f0219b7621ed1e5c8c70b","queuetimems":0,\
> "method":"get","totalColumns":1,"maxVersions":1,"storeLimit":-1}
> {code}
> the above would suggest that all columns of myTable:CF1 are being requested
> for the given row. But in reality there could be filters in effect (such as
> ColumnPrefixFilter, ColumnRangeFilter, TimestampsFilter() etc.). We should
> enhance the slow query log to capture & report this information.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
