[ 
https://issues.apache.org/jira/browse/HBASE-19561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16298855#comment-16298855
 ] 

Hudson commented on HBASE-19561:
--------------------------------

FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4261 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/4261/])
HBASE-19561 maxCacheSize in CacheEvictionStats can't be accumulated (tedyu: rev 
55fefd4b5a43ab7221a08a1410a113b9c41bbd60)
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java


> maxCacheSize in CacheEvictionStats can't be accumulated repeatedly When 
> dealing with each region
> ------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-19561
>                 URL: https://issues.apache.org/jira/browse/HBASE-19561
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: Guangxu Cheng
>            Assignee: Guangxu Cheng
>             Fix For: 2.0.0-beta-1
>
>         Attachments: HBASE-19561.master.001.patch
>
>
> {code:title=HRegionServer.java|borderStyle=solid}
>   public CacheEvictionStats clearRegionBlockCache(Region region) {
>     BlockCache blockCache = this.getCacheConfig().getBlockCache();
>     long evictedBlocks = 0;
>     for(Store store : region.getStores()) {
>       for(StoreFile hFile : store.getStorefiles()) {
>         evictedBlocks += 
> blockCache.evictBlocksByHfileName(hFile.getPath().getName());
>       }
>     }
>     return CacheEvictionStats.builder()
>         .withEvictedBlocks(evictedBlocks)
>         .withMaxCacheSize(blockCache.getMaxSize())
>         .build();
>   }
> {code}
> BlockCache is the regionserver level object.If we accumulate this value for 
> each region, we will get a wrong result.
> The value of maxCacheSize should be set to BlockCache.getMaxSize() after 
> processing all the regions on this regionserver.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to