[
https://issues.apache.org/jira/browse/HBASE-19543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299500#comment-16299500
]
Duo Zhang commented on HBASE-19543:
-----------------------------------
{quote}
1. Can we use ServerName to replace old String(region server name)?
{quote}
Agree.
{quote}
2. Add a addQueue method. The old impl use zk, so it add a new queue by call
ZKUtil.createWithParents when addLog.
{quote}
When will we call this method? When adding a peer? And also at the
initialization of region server? Sounds good.
{quote}
3. Do we need removeReplicatorIfQueueIsEmpty? This can be done by the caller.
{quote}
I do not follow. How do caller do this? Modify zk directly?
{quote}
4. Do we need getAllWALs? This only used by cleaner.
{quote}
Ditto. Then how do the cleaner get the files to delete?
{quote}
5. Method name: use Log or WAL?
{quote}
Let's change to WAL.
For the naming and javadoc, will do.
Thanks.
> Abstract a replication storage interface to extract the zk specific code
> ------------------------------------------------------------------------
>
> Key: HBASE-19543
> URL: https://issues.apache.org/jira/browse/HBASE-19543
> Project: HBase
> Issue Type: Sub-task
> Components: proc-v2, Replication
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Attachments: HBASE-19543-HBASE-19397.patch,
> HBASE-19543-HBASE-19397.patch
>
>
> For now, we will do sanity checks at the same time when updating replication
> peer. But this is not a safe way for procedure based replication peer
> modification.
> For the old zk watcher way, the only thing is updating the data on zk, so if
> the data is updated and then we crashes, there is no problem.
> For the new procedure way, we need to trigger refresh by ourselves after
> updating zk. If we crashes after the updating and before we record the state
> change of the procedure, we may fail with IllegalArgumentException when we
> execute the procedure next time since the data on zk has already been updated.
> So the current way is to do sanity checks in PRE_PEER_MODIFICATION state, and
> in UPDATE_STORAGE state we will not do sanity checks any more, just
> update(overwrite) the peer storage.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
