[
https://issues.apache.org/jira/browse/HBASE-10092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-10092:
--------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Release Note:
We now have slf4j as our front-end. Be careful adding logging from here on out;
make sure it slf4j.
>From here on out, as us devs go, we need to convert log messages from being
>'guarded' -- i.e. surrounded by if (LOG.isDebugEnabled...) -- to instead being
>parameterized log messages. e.g. the latter rather than the former in the
>below:
logger.debug("The new entry is "+entry+".");
logger.debug("The new entry is {}.", entry);
See [1] for background on perf benefits.
Note, FATAL log level is not present in slf4j. It is noted as a Marker but
won't show in logs as a LEVEL.
1. https://www.slf4j.org/faq.html#logging_performance
Status: Resolved (was: Patch Available)
Pushed to branch-2 and master.
Filed HBASE-19577 for changing backend off log4j1, an EOL'd tech.
> Move to slf4j
> -------------
>
> Key: HBASE-10092
> URL: https://issues.apache.org/jira/browse/HBASE-10092
> Project: HBase
> Issue Type: Sub-task
> Reporter: stack
> Assignee: Balazs Meszaros
> Priority: Critical
> Fix For: 2.0.0-beta-1
>
> Attachments: 10092.txt, 10092v2.txt, HBASE-10092-preview-v0.patch,
> HBASE-10092.master.001.patch, HBASE-10092.master.002.patch,
> HBASE-10092.master.003.patch, HBASE-10092.master.004.patch, HBASE-10092.patch
>
>
> Allows logging with less friction. See http://logging.apache.org/log4j/2.x/
> This rather radical transition can be done w/ minor change given they have an
> adapter for apache's logging, the one we use. They also have and adapter for
> slf4j so we likely can remove at least some of the 4 versions of this module
> our dependencies make use of.
> I made a start in attached patch but am currently stuck in maven dependency
> resolve hell courtesy of our slf4j. Fixing will take some concentration and
> a good net connection, an item I currently lack. Other TODOs are that will
> need to fix our little log level setting jsp page -- will likely have to undo
> our use of hadoop's tool here -- and the config system changes a little.
> I will return to this project soon. Will bring numbers.
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
