[
https://issues.apache.org/jira/browse/HBASE-19575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299998#comment-16299998
]
Peter Somogyi commented on HBASE-19575:
---------------------------------------
Good patch!
- Mutation.java uses incorrect Preconditions import. It should be
org.apache.hadoop.hbase.shaded.com.google.common.base.Preconditions
- In testAppendCopyConstructor and testIncrementCopyConstructor you don't
specify TimeRange. Can you add it to the tests?
> add copy constructor to Mutation
> --------------------------------
>
> Key: HBASE-19575
> URL: https://issues.apache.org/jira/browse/HBASE-19575
> Project: HBase
> Issue Type: Sub-task
> Reporter: Chia-Ping Tsai
> Assignee: Chia-Ping Tsai
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19575.v0.patch
>
>
> Put, Delete, Increment, and Append have similar code in copy constructor. Let
> us move the copy constructor to the upper class - mutation - so as to remove
> the duplicate code. BTW, the copy constructor of Put miss the clone of
> priority.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
