[ https://issues.apache.org/jira/browse/HBASE-19525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16300898#comment-16300898 ]
Guanghao Zhang commented on HBASE-19525: ---------------------------------------- bq. because there are diff implementations for ReplicationPeer The different impl will be moved to storage service. So only have one impl for ReplicationPeer. bq. Still need an extra method added in ReplicationPeer to read peer state We only add method to the impl not the interface. Because the interface is IA.LimitPrivate. bq. I think you mean it's more readable in that way. Yeah. More readable. Current code is confused. Because the peer config/state is used by ReplicationSource. So the procedure should tell the changed event to ReplicationSource. This will be easy to understand. > RS side changes for moving peer modification from zk watcher to procedure > ------------------------------------------------------------------------- > > Key: HBASE-19525 > URL: https://issues.apache.org/jira/browse/HBASE-19525 > Project: HBase > Issue Type: Sub-task > Components: proc-v2, Replication > Reporter: Duo Zhang > Assignee: Zheng Hu > Fix For: HBASE-19397 > > Attachments: HBASE-19525.HBASE-19397.v1.patch, > HBASE-19525.HBASE-19397.v2.patch, HBASE-19525.HBASE-19397.v3.patch, > HBASE-19525.HBASE-19397.v4.patch, HBASE-19525.HBASE-19397.v5.patch, > HBASE-19525.HBASE-19397.v6.patch, HBASE-19525.HBASE-19397.v6.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)