[
https://issues.apache.org/jira/browse/HBASE-19578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301022#comment-16301022
]
Reid Chan edited comment on HBASE-19578 at 12/22/17 6:44 AM:
-------------------------------------------------------------
Get your mind, in ProcedureWALFile.class, method removeFile()
{code}
if (walArchiveDir != null) {
// logFile.getName() will return pv2-xxx.log,
// so it renames to {hbase.rootdir}/oldWALs/pv2-xxx.log.
Path archivedFile = new Path(walArchiveDir, logFile.getName());
if (!fs.rename(logFile, archivedFile)) {
LOG.warn("Failed archive of " + logFile + ", deleting");
} else {
archived = true;
}
}
{code}
I thought it was on purpose, but now it looks like not archived as your
intention? [~stack].
was (Author: reidchan):
Get your mind, in ProcedureWALFile.class, method removeFile()
{code}
if (walArchiveDir != null) {
// logFile.getName() will return pv2-xxx.log,
// so it renames to {hbase.rootdir}/oldWALs/pv2-xxx.log.
Path archivedFile = new Path(walArchiveDir, logFile.getName());
if (!fs.rename(logFile, archivedFile)) {
LOG.warn("Failed archive of " + logFile + ", deleting");
} else {
archived = true;
}
}
{code}
I thought it was on purpose, but looks like not?
> MasterProcWALs cleaning is incorrect
> ------------------------------------
>
> Key: HBASE-19578
> URL: https://issues.apache.org/jira/browse/HBASE-19578
> Project: HBase
> Issue Type: Bug
> Components: amv2
> Affects Versions: 2.0.0-alpha-4
> Reporter: Peter Somogyi
> Assignee: Peter Somogyi
> Priority: Critical
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19578.master.001.patch,
> HBASE-19578.master.001.patch, HBASE-19578.master.001.patch
>
>
> Pattern used for MasterProcWALs cleaning is incorrect. The logs are deleted
> from oldWALs directory as invalid files.
> 2017-12-21 11:32:37,980 WARN [ForkJoinPool-1-worker-2] cleaner.CleanerChore:
> Found a wrongly formatted file:
> file:/Users/peter.somogyi/tmp/hbase/oldWALs/pv2-00000000000000000001.log -
> will delete it.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
