[
https://issues.apache.org/jira/browse/HBASE-10092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301972#comment-16301972
]
Mike Drob commented on HBASE-10092:
-----------------------------------
question about the changes to bin scripts, and possibly other places -
{code:title=bin/draining_servers.rb}
-# Create a logger and disable the DEBUG-level annoying client logging
-def configureLogging(options)
- apacheLogger = LogFactory.getLog(NAME)
- # Configure log4j to not spew so much
- unless options[:debug]
- logger = org.apache.log4j.Logger.getLogger('org.apache.hadoop.hbase')
- logger.setLevel(org.apache.log4j.Level::WARN)
- logger = org.apache.log4j.Logger.getLogger('org.apache.zookeeper')
- logger.setLevel(org.apache.log4j.Level::WARN)
- end
- apacheLogger
-end
-
# Create a logger and save it to ruby global
-$LOG = configureLogging(options)
+$LOG = LoggerFactory.getLogger(NAME)
{code}
So now this script will output a lot more log messaging? We don't have the
debug flag to turn off the verboseness of zk logger now, so we will always get
lots of messages? I haven't tried this yet, so maybe I'm misunderstanding the
change.
> Move to slf4j
> -------------
>
> Key: HBASE-10092
> URL: https://issues.apache.org/jira/browse/HBASE-10092
> Project: HBase
> Issue Type: Sub-task
> Reporter: stack
> Assignee: Balazs Meszaros
> Priority: Critical
> Fix For: 2.0.0-beta-1
>
> Attachments: 10092.txt, 10092v2.txt,
> HBASE-10092-addendum-2.master.002.patch, HBASE-10092-addendum.patch,
> HBASE-10092-preview-v0.patch, HBASE-10092.master.001.patch,
> HBASE-10092.master.002.patch, HBASE-10092.master.003.patch,
> HBASE-10092.master.004.patch, HBASE-10092.patch
>
>
> Allows logging with less friction. See http://logging.apache.org/log4j/2.x/
> This rather radical transition can be done w/ minor change given they have an
> adapter for apache's logging, the one we use. They also have and adapter for
> slf4j so we likely can remove at least some of the 4 versions of this module
> our dependencies make use of.
> I made a start in attached patch but am currently stuck in maven dependency
> resolve hell courtesy of our slf4j. Fixing will take some concentration and
> a good net connection, an item I currently lack. Other TODOs are that will
> need to fix our little log level setting jsp page -- will likely have to undo
> our use of hadoop's tool here -- and the config system changes a little.
> I will return to this project soon. Will bring numbers.
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
