[
https://issues.apache.org/jira/browse/HBASE-19550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16302642#comment-16302642
]
Chia-Ping Tsai commented on HBASE-19550:
----------------------------------------
Thanks for you reviews. [~tedyu]
bq. The implementation is similar to PrivateCellUtil#getTag(). Is it possible
to refactor the code ?
I followed the logic from other ExtendedCell impls. We should move the impl to
ExtenedCell to be a default method. That was the Q I raised to [~ram_krish]. We
can file another jira for the refactor after ram gives the input.
Other comments will be addressed in next patch.
> Wrap the Mutation in cp layer to make sure all passed cells are of
> ExtendedCell
> -------------------------------------------------------------------------------
>
> Key: HBASE-19550
> URL: https://issues.apache.org/jira/browse/HBASE-19550
> Project: HBase
> Issue Type: Task
> Reporter: Chia-Ping Tsai
> Assignee: Chia-Ping Tsai
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19550.v0.patch
>
>
> We assume all cells in server are of ExtendedCell. However, cp user can add
> their cell impl via Put#add(Cell) in observer. That will cause
> UnsupportedOperationException when rs try to update the cell's timestamp and
> seq Id. We should do something for cp user...For example, wrap the passed
> cells to be a extendcell type.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
