[ 
https://issues.apache.org/jira/browse/HBASE-4658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198318#comment-13198318
 ] 

Phabricator commented on HBASE-4658:
------------------------------------

sc has accepted the revision "[jira] [HBASE-4658] Put attributes are not 
exposed via the ThriftServer".

  Looks good to me

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:1300 I 
would prefer the style

  for (Map.Entry<ByteBuffer, ByteBuffer> entry : attributes.entrySet()) {
    ...
  }

REVISION DETAIL
  https://reviews.facebook.net/D1563

                
> Put attributes are not exposed via the ThriftServer
> ---------------------------------------------------
>
>                 Key: HBASE-4658
>                 URL: https://issues.apache.org/jira/browse/HBASE-4658
>             Project: HBase
>          Issue Type: Bug
>          Components: thrift
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>         Attachments: D1563.1.patch, D1563.1.patch, D1563.1.patch, 
> ThriftPutAttributes1.txt
>
>
> The Put api also takes in a bunch of arbitrary attributes that an application 
> can use to associate metadata with each put operation. This is not exposed 
> via Thrift.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to