[
https://issues.apache.org/jira/browse/HBASE-5186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198326#comment-13198326
]
Phabricator commented on HBASE-5186:
------------------------------------
sc has commented on the revision "HBASE-5186 [jira] Add metrics to
ThriftServer".
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/thrift/CallQueue.java:131 If there is
another thread also adding elements at the same time, we may remove the wrong
element. It is not clean to me how to solve the concurrency problem here.
Ted: Do you have any suggestions?
REVISION DETAIL
https://reviews.facebook.net/D1461
> Add metrics to ThriftServer
> ---------------------------
>
> Key: HBASE-5186
> URL: https://issues.apache.org/jira/browse/HBASE-5186
> Project: HBase
> Issue Type: Improvement
> Reporter: Scott Chen
> Assignee: Scott Chen
> Attachments: 5186-v9.txt, HBASE-5186.D1461.1.patch,
> HBASE-5186.D1461.2.patch, HBASE-5186.D1461.3.patch, HBASE-5186.D1461.4.patch,
> HBASE-5186.D1461.5.patch, HBASE-5186.D1461.6.patch, HBASE-5186.D1461.7.patch,
> HBASE-5186.D1461.8.patch
>
>
> It will be useful to have some metrics (queue length, waiting time,
> processing time ...) similar to Hadoop RPC server. This allows us to monitor
> system health also provide a tool to diagnose the problem where thrift calls
> are slow.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
