[
https://issues.apache.org/jira/browse/HBASE-19654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305655#comment-16305655
]
Dave Latham commented on HBASE-19654:
-------------------------------------
I think that log message is misleading. I believe the model for the log
cleaners is that if any cleaner in the chain wants to hold on to a file, then
it will not be deleted. So even though the ReplicationLogCleaner is ok to
delete those files, they still won't be deleted if some other log cleaner (e.g.
TimeToLiveProcedureWALCleaner) wants to hold on to them. A better log message
might be {{"Didn't find this log in ZK, not retaining for replication: " +
hlog}}
> ReplicationLogCleaner should not delete MasterProcedureWALs
> -----------------------------------------------------------
>
> Key: HBASE-19654
> URL: https://issues.apache.org/jira/browse/HBASE-19654
> Project: HBase
> Issue Type: Bug
> Affects Versions: 2.0.0-beta-1
> Reporter: Peter Somogyi
> Assignee: Reid Chan
> Fix For: 2.0.0-beta-2
>
>
> The pv2 logs are deleted by ReplicationLogCleaner. It does not check if
> TimeToLiveProcedureWALCleaner needs to keep the files.
> {noformat}
> 2017-12-27 19:59:02,261 DEBUG [ForkJoinPool-1-worker-17]
> cleaner.CleanerChore: CleanerTask 391 starts cleaning dirs and files under
> hdfs://ve0524.halxg.cloudera.com:8020/hbase/oldWALs and itself.
> 2017-12-27 19:59:02,279 DEBUG [ForkJoinPool-1-worker-17]
> master.ReplicationLogCleaner: Didn't find this log in ZK, deleting:
> pv2-00000000000000000001.log
> 2017-12-27 19:59:02,279 DEBUG [ForkJoinPool-1-worker-17]
> master.ReplicationLogCleaner: Didn't find this log in ZK, deleting:
> pv2-00000000000000000002.log
> 2017-12-27 19:59:02,279 DEBUG [ForkJoinPool-1-worker-17]
> master.ReplicationLogCleaner: Didn't find this log in ZK, deleting:
> pv2-00000000000000000003.log
> 2017-12-27 19:59:02,279 DEBUG [ForkJoinPool-1-worker-17]
> master.ReplicationLogCleaner: Didn't find this log in ZK, deleting:
> pv2-00000000000000000004.log
> 2017-12-27 19:59:02,279 DEBUG [ForkJoinPool-1-worker-17]
> master.ReplicationLogCleaner: Didn't find this log in ZK, deleting:
> pv2-00000000000000000005.log
> 2017-12-27 19:59:02,279 DEBUG [ForkJoinPool-1-worker-17]
> master.ReplicationLogCleaner: Didn't find this log in ZK, deleting:
> pv2-00000000000000000006.log
> 2017-12-27 19:59:02,279 DEBUG [ForkJoinPool-1-worker-17]
> master.ReplicationLogCleaner: Didn't find this log in ZK, deleting:
> pv2-00000000000000000007.log
> 2017-12-27 19:59:02,279 DEBUG [ForkJoinPool-1-worker-17]
> master.ReplicationLogCleaner: Didn't find this log in ZK, deleting:
> pv2-00000000000000000008.log
> 2017-12-27 19:59:02,279 DEBUG [ForkJoinPool-1-worker-17]
> master.ReplicationLogCleaner: Didn't find this log in ZK, deleting:
> pv2-00000000000000000009.log
> 2017-12-27 19:59:02,279 DEBUG [ForkJoinPool-1-worker-17]
> master.ReplicationLogCleaner: Didn't find this log in ZK, deleting:
> pv2-00000000000000000010.log
> 2017-12-27 19:59:02,279 DEBUG [ForkJoinPool-1-worker-17]
> master.ReplicationLogCleaner: Didn't find this log in ZK, deleting:
> pv2-00000000000000000011.log
> 2017-12-27 19:59:02,279 DEBUG [ForkJoinPool-1-worker-17]
> master.ReplicationLogCleaner: Didn't find this log in ZK, deleting:
> pv2-00000000000000000012.log
> 2017-12-27 19:59:02,279 DEBUG [ForkJoinPool-1-worker-17]
> master.ReplicationLogCleaner: Didn't find this log in ZK, deleting:
> pv2-00000000000000000013.log
> 2017-12-27 19:59:02,279 DEBUG [ForkJoinPool-1-worker-17]
> master.ReplicationLogCleaner: Didn't find this log in ZK, deleting:
> pv2-00000000000000000014.log
> 2017-12-27 19:59:02,280 DEBUG [ForkJoinPool-1-worker-17]
> master.ReplicationLogCleaner: Didn't find this log in ZK, deleting:
> pv2-00000000000000000015.log
> 2017-12-27 19:59:02,280 DEBUG [ForkJoinPool-1-worker-17]
> master.ReplicationLogCleaner: Didn't find this log in ZK, deleting:
> pv2-00000000000000000016.log
> 2017-12-27 19:59:02,280 DEBUG [ForkJoinPool-1-worker-17]
> master.ReplicationLogCleaner: Didn't find this log in ZK, deleting:
> pv2-00000000000000000017.log
> 2017-12-27 19:59:02,280 DEBUG [ForkJoinPool-1-worker-17]
> master.ReplicationLogCleaner: Didn't find this log in ZK, deleting:
> pv2-00000000000000000018.log
> 2017-12-27 19:59:02,280 DEBUG [ForkJoinPool-1-worker-17]
> master.ReplicationLogCleaner: Didn't find this log in ZK, deleting:
> pv2-00000000000000000019.log
> 2017-12-27 19:59:02,280 DEBUG [ForkJoinPool-1-worker-17]
> master.ReplicationLogCleaner: Didn't find this log in ZK, deleting:
> pv2-00000000000000000020.log
> 2017-12-27 19:59:02,280 DEBUG [ForkJoinPool-1-worker-17]
> master.ReplicationLogCleaner: Didn't find this log in ZK, deleting:
> pv2-00000000000000000021.log
> 2017-12-27 19:59:02,280 DEBUG [ForkJoinPool-1-worker-17]
> master.ReplicationLogCleaner: Didn't find this log in ZK, deleting:
> pv2-00000000000000000022.log
> 2017-12-27 19:59:02,280 DEBUG [ForkJoinPool-1-worker-17]
> master.ReplicationLogCleaner: Didn't find this log in ZK, deleting:
> pv2-00000000000000000023.log
> 2017-12-27 19:59:02,280 DEBUG [ForkJoinPool-1-worker-17]
> master.ReplicationLogCleaner: Didn't find this log in ZK, deleting:
> pv2-00000000000000000024.log
> 2017-12-27 19:59:02,280 DEBUG [ForkJoinPool-1-worker-17]
> master.ReplicationLogCleaner: Didn't find this log in ZK, deleting:
> pv2-00000000000000000025.log
> 2017-12-27 19:59:02,280 DEBUG [ForkJoinPool-1-worker-17]
> master.ReplicationLogCleaner: Didn't find this log in ZK, deleting:
> pv2-00000000000000000026.log
> 2017-12-27 19:59:02,280 DEBUG [ForkJoinPool-1-worker-17]
> master.ReplicationLogCleaner: Didn't find this log in ZK, deleting:
> pv2-00000000000000000027.log
> 2017-12-27 19:59:02,280 DEBUG [ForkJoinPool-1-worker-17]
> master.ReplicationLogCleaner: Didn't find this log in ZK, deleting:
> pv2-00000000000000000028.log
> 2017-12-27 19:59:02,280 DEBUG [ForkJoinPool-1-worker-17]
> master.ReplicationLogCleaner: Didn't find this log in ZK, deleting:
> pv2-00000000000000000029.log
> 2017-12-27 19:59:02,280 DEBUG [ForkJoinPool-1-worker-17]
> master.ReplicationLogCleaner: Didn't find this log in ZK, deleting:
> pv2-00000000000000000030.log
> 2017-12-27 19:59:02,280 DEBUG [ForkJoinPool-1-worker-17]
> master.ReplicationLogCleaner: Didn't find this log in ZK, deleting:
> pv2-00000000000000000031.log
> 2017-12-27 19:59:02,280 DEBUG [ForkJoinPool-1-worker-17]
> master.ReplicationLogCleaner: Didn't find this log in ZK, deleting:
> pv2-00000000000000000032.log
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
