[
https://issues.apache.org/jira/browse/HBASE-19666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16306234#comment-16306234
]
Jingyun Tian commented on HBASE-19666:
--------------------------------------
test of TestDefaultCompactSelection$testCompactionRatio() has code like this:
{code}
this.conf.setLong("hbase.hstore.compaction.min.size", 1);
store.storeEngine.getCompactionPolicy().setConf(conf);
compactEquals(sfCreate(512,256,128,64,32,16,8,4,2,1), 4,2,1);
{code}
that set the hbase.hstore.compaction.min.size to 1, and when we filter files to
do compaction, there is a check:
{code}
if (size >= comConf.getMinCompactSize()
&& !filesInRatio(potentialMatchFiles, currentRatio)) {
continue;
}
{code}
Since the smallest file is 1, there is no possible that size could smaller than
comConf.getMinCompactSize().
For check of filesInRatio, there is a constraint that single file size should
small than sum of other files. But for the file combinations of
512,256,128,64,32,16,8,4,2,1, the single file size always bigger than the sum
of rest files.
> hadoop.hbase.regionserver.TestDefaultCompactSelection test failed
> -----------------------------------------------------------------
>
> Key: HBASE-19666
> URL: https://issues.apache.org/jira/browse/HBASE-19666
> Project: HBase
> Issue Type: Bug
> Affects Versions: 2.0
> Reporter: Jingyun Tian
> Priority: Critical
>
> hadoop.hbase.regionserver.TestDefaultCompactSelection
> [ERROR] Failures:
> [ERROR]
> TestDefaultCompactSelection.testCompactionRatio:74->TestCompactionPolicy.compactEquals:182->TestCompactionPolicy.compactEquals:201
> expected:<[[4, 2, 1]]> but was:<[[]]>
> [ERROR]
> TestDefaultCompactSelection.testStuckStoreCompaction:145->TestCompactionPolicy.compactEquals:182->TestCompactionPolicy.compactEquals:201
> expected:<[[]30, 30, 30]> but was:<[[99, 30, ]30, 30, 30]>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
