[ https://issues.apache.org/jira/browse/HBASE-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16306425#comment-16306425 ]
Chia-Ping Tsai commented on HBASE-8518: --------------------------------------- Replace the "hbase.hregion.impl" by HConstants.REGION_IMPL {code} public void testRecoveredEditsReplayCompaction(boolean mismatchedRegionName) throws Exception { + CONF.setClass("hbase.hregion.impl", HRegionForTesting.class, Region.class); {code} The IA.Private is unnecessary in this test file. {code} + @InterfaceAudience.Private + public static class HStoreForTesting extends HStore { {code} {code} + @InterfaceAudience.Private + public static class HRegionForTesting extends HRegion { {code} > Get rid of hbase.hstore.compaction.complete setting > --------------------------------------------------- > > Key: HBASE-8518 > URL: https://issues.apache.org/jira/browse/HBASE-8518 > Project: HBase > Issue Type: Improvement > Reporter: Sergey Shelukhin > Assignee: Kuan-Po Tseng > Priority: Minor > Labels: beginner > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-8518-1.patch, HBASE-8518.master.v0.patch, > HBASE-8518.master.v1.patch, HBASE-8518.master.v2.patch, > HBASE-8518.master.v3.patch, HBASE-8518.master.v4.patch, HBASE-8518.wip.patch > > > hbase.hstore.compaction.complete is a strange setting that causes the > finished compaction to not complete (files are just left in tmp) in HStore. > It's used by one test. > The setting with the same name is also used by CompactionTool, but that usage > is semi-unrelated and could probably be removed easily. -- This message was sent by Atlassian JIRA (v6.4.14#64029)