[jira] [Updated] (HBASE-19672) Correct comments for default values of major compaction in SortedCompactionPolicy#getNextMajorCompactTime()

[Ted Yu (JIRA)]

     [ 
https://issues.apache.org/jira/browse/HBASE-19672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Yu updated HBASE-19672:
---------------------------
       Resolution: Fixed
     Hadoop Flags: Reviewed
    Fix Version/s: 2.0.0-beta-2
           Status: Resolved  (was: Patch Available)

Thanks for the patch, Xiang

> Correct comments for default values of major compaction in 
> SortedCompactionPolicy#getNextMajorCompactTime()
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-19672
>                 URL: https://issues.apache.org/jira/browse/HBASE-19672
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Xiang Li
>            Assignee: Xiang Li
>            Priority: Minor
>             Fix For: 2.0.0-beta-2
>
>         Attachments: HBASE-19672.master.000.patch, 
> HBASE-19672.master.001.patch, HBASE-19672.master.002.patch
>
>
> {code:title=hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/SortedCompactionPolicy.java|borderStyle=solid}
> public long getNextMajorCompactTime(Collection<HStoreFile> filesToCompact) {
> {
>     // default = 24hrs
>    long period = comConf.getMajorCompactionPeriod();
>     ...
>     // default = 20% = +/- 4.8 hrs
>     double jitterPct = comConf.getMajorCompactionJitter();
>     ...
> }
> {code}
> If I get it correctly, currently, default major compaction period is 7 
> days，and jitter is 0.5, so 3.5 days.
> We could either remove those comments, or add \{@link\} to link to the 
> default value definitions.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)