[
https://issues.apache.org/jira/browse/HBASE-19551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16307075#comment-16307075
]
Toshihiro Suzuki commented on HBASE-19551:
------------------------------------------
I just attached a new patch for branch-1 which is added test code.
It seemed original TestHBaseFsck#testRegionBoundariesCheck() was broken and
TestHBaseFsck#testHDFSRegioninfoMissingAndCheckRegionBoundary() was unrelated
to "hbck -boundaries" feature.
Regarding master branch, seems like the hbck test code was removed by
HBASE-19272.
> hbck -boundaries doesn't work correctly
> ---------------------------------------
>
> Key: HBASE-19551
> URL: https://issues.apache.org/jira/browse/HBASE-19551
> Project: HBase
> Issue Type: Bug
> Components: hbck
> Reporter: Toshihiro Suzuki
> Assignee: Toshihiro Suzuki
> Attachments: HBASE-19551.branch-1.patch, HBASE-19551.patch
>
>
> Currently, in HBaseFsck#checkRegionBoundaries(), it seems like keys from
> reader.getFirstKey() and reader.getLastKey() are directly compared by
> ByteArrayComparator:
> https://github.com/apache/hbase/blob/9d0c7c6dfbcba0907cbbc2244eac570fcc4d58a5/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java#L864-L865
> https://github.com/apache/hbase/blob/9d0c7c6dfbcba0907cbbc2244eac570fcc4d58a5/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java#L869-L870
> This is not correct because the keys consist of a key length and key itself.
> We should compare rowkeys or the only key itself (by removing a key length).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
