[jira] [Commented] (HBASE-19677) Miscellaneous HFileCleaner.java Improvements

[BELUGA BEHR (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HBASE-19677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16307080#comment-16307080
 ] 

BELUGA BEHR commented on HBASE-19677:
-------------------------------------

I do not think test failures are related...

{code}
java.lang.OutOfMemoryError: Java heap space
        at java.nio.HeapByteBuffer.<init>(HeapByteBuffer.java:57)
        at java.nio.ByteBuffer.allocate(ByteBuffer.java:335)
        at 
org.apache.hadoop.hbase.regionserver.OnheapChunk.allocateDataBuffer(OnheapChunk.java:41)
        at org.apache.hadoop.hbase.regionserver.Chunk.init(Chunk.java:100)
        at 
org.apache.hadoop.hbase.regionserver.ChunkCreator.getChunk(ChunkCreator.java:151)
        at 
org.apache.hadoop.hbase.regionserver.ChunkCreator.getChunk(ChunkCreator.java:120)
        at 
org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.getOrMakeChunk(MemStoreLABImpl.java:272)
        at 
org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.copyCellInto(MemStoreLABImpl.java:148)
        at 
org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.copyCellInto(MemStoreLABImpl.java:111)
        at 
org.apache.hadoop.hbase.regionserver.TestMemstoreLABWithoutPool$1.run(TestMemstoreLABWithoutPool.java:156)
{code}

> Miscellaneous HFileCleaner.java Improvements
> --------------------------------------------
>
>                 Key: HBASE-19677
>                 URL: https://issues.apache.org/jira/browse/HBASE-19677
>             Project: HBase
>          Issue Type: Improvement
>          Components: hbase
>    Affects Versions: 3.0.0
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Trivial
>         Attachments: HBASE-19677.1.patch
>
>
> * Remove superfluous logging code guards
> * Introduce SLF4J parameter logging
> * Some simplifying:
> {code}
> -    for (HFileDeleteTask task : largeFileQueue) {
> -      leftOverTasks.add(task);
> -    }
> -    for (HFileDeleteTask task : smallFileQueue) {
> -      leftOverTasks.add(task);
> -    }
> +    leftOverTasks.addAll(largeFileQueue);
> +    leftOverTasks.addAll(smallFileQueue);
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)