[
https://issues.apache.org/jira/browse/HBASE-19677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16308636#comment-16308636
]
Appy commented on HBASE-19677:
------------------------------
I liked the change from just thread name to thread name + priority + groupname.
Thanks for the nice fixes [~belugabehr]!
> Miscellaneous HFileCleaner Improvements
> ---------------------------------------
>
> Key: HBASE-19677
> URL: https://issues.apache.org/jira/browse/HBASE-19677
> Project: HBase
> Issue Type: Improvement
> Components: hbase
> Affects Versions: 3.0.0
> Reporter: BELUGA BEHR
> Assignee: BELUGA BEHR
> Priority: Trivial
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19677.1.patch
>
>
> * Remove superfluous logging code guards
> * Introduce SLF4J parameter logging
> * Some simplifying:
> {code}
> - for (HFileDeleteTask task : largeFileQueue) {
> - leftOverTasks.add(task);
> - }
> - for (HFileDeleteTask task : smallFileQueue) {
> - leftOverTasks.add(task);
> - }
> + leftOverTasks.addAll(largeFileQueue);
> + leftOverTasks.addAll(smallFileQueue);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
