[
https://issues.apache.org/jira/browse/HBASE-19674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16309368#comment-16309368
]
Niels Basjes commented on HBASE-19674:
--------------------------------------
[~Jan Hentschel]:
I checked this and found
http://hbase.apache.org/book.html#submitting.patches.create
{quote}Patch name is automatically formatted as (JIRA).(branch name).(patch
number).patch to follow Yetus' naming rules.{quote}
And according to
https://yetus.apache.org/documentation/0.6.0/precommit-patchnames/ (which is
mentioned if a patch needs rebasing) can handle both orderings correctly.
I have created several patches using this script over the last few days and it
works fine with Yetus.
https://issues.apache.org/jira/browse/HBASE-19673
> make_patch.sh version increment fails
> -------------------------------------
>
> Key: HBASE-19674
> URL: https://issues.apache.org/jira/browse/HBASE-19674
> Project: HBase
> Issue Type: Improvement
> Reporter: Niels Basjes
> Assignee: Niels Basjes
> Attachments: HBASE-19674.20171230-131310.patch,
> HBASE-19674.20171230-152443.patch
>
>
> I have 5 things in the {{make_patch.sh}} script where I see room for
> improvement:
> 1) BUG:
> Assume my working branch is called {{HBASE-19673}}
> Now if I run
> {{dev-support/make_patch.sh -b origin/branch-1}}
> a patch is created with the name
> {{~/patches/HBASE-19673.v1.branch-1.patch}}
> When I run the same command again the version is not incremented.
> The reason is that the script checks for {{HBASE-19673.v1.patch}} which is
> without the branch name.
> 2) Messy: The first patch created does NOT include the version tag at all.
> 3) Messy: The version starts with '1' so when we reach patch '10' they will
> be ordered incorrectly in Jira (which is based on name)
> 4) New feature: I personally prefer using the timestamp as the 'version' of
> the patch because these are much easier to order.
> 5) Messy: If you for example only have one file {{HBASE-19674.v05.patch}}
> then the next file generated will be {{HBASE-19674.v01.patch}} instead of the
> expected {{HBASE-19674.v06.patch}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
