[
https://issues.apache.org/jira/browse/HBASE-19702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16310676#comment-16310676
]
Xiang Li commented on HBASE-19702:
----------------------------------
{code:title=hbase-common/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfo.java|borderStyle=solid}
RSGroupInfo(String name, SortedSet<Address> servers, SortedSet<TableName>
tables) {
this.name = name;
this.servers = servers == null? new TreeSet<>(): servers;
this.servers.addAll(servers);
this.tables = new TreeSet<>(tables);
}
{code}
2 improvements could be made:
* When servers is not null, addAll(servers) tries to add all items in servers
again. Seems not needed
* new TreeSet<>(tables) has not null check. The constructor of TreeSet does not
do the null check either. It leads to NullPointerException if tables is null
> Improve RSGroupInfo constructor
> -------------------------------
>
> Key: HBASE-19702
> URL: https://issues.apache.org/jira/browse/HBASE-19702
> Project: HBase
> Issue Type: Improvement
> Reporter: Xiang Li
> Priority: Minor
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
