[ 
https://issues.apache.org/jira/browse/HBASE-19703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311227#comment-16311227
 ] 

ramkrishna.s.vasudevan commented on HBASE-19703:
------------------------------------------------

I think since the Split proc is in master now 
{code}
TableDescriptor hTableDescriptor =
            env.getMasterServices().getTableDescriptors().get(tableName);
{code}
You will know the table name from the regionInfo. And need instantiate the 
split policy every time from conf. Yes this may be a costly operation. Do we 
need a TableDescriptorCache for these type of cases (in future)? I thikn since 
we cannot have region ref here I think this is the best way to do? 

> Functionality added as part of HBASE-12583 is not working after moving the 
> split code to master
> -----------------------------------------------------------------------------------------------
>
>                 Key: HBASE-19703
>                 URL: https://issues.apache.org/jira/browse/HBASE-19703
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Rajeshbabu Chintaguntla
>            Assignee: Rajeshbabu Chintaguntla
>             Fix For: 2.0.0-beta-2
>
>         Attachments: HBASE-19703-WIP.patch
>
>
> As part of HBASE-12583 we are passing split policy to 
> HRegionFileSystem#splitStoreFile so that we can allow to create reference 
> files even the split key is out of HFile key range. This is needed for Local 
> Indexing implementation in Phoenix. But now after moving the split code to 
> master just passing null for split policy.
> {noformat}
>     final String familyName = Bytes.toString(family);
>     final Path path_first =
>         regionFs.splitStoreFile(this.daughter_1_RI, familyName, sf, splitRow, 
> false, null);
>     final Path path_second =
>         regionFs.splitStoreFile(this.daughter_2_RI, familyName, sf, splitRow, 
> true, null);
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to